review comment: add HACK comment

estebank · estebank · commit 87ef96d3946e · 2019-04-22T13:14:43.000-07:00
diff --git a/src/librustc_mir/hair/pattern/mod.rs b/src/librustc_mir/hair/pattern/mod.rs
@@ -986,6 +986,8 @@ impl<'a, 'tcx> PatternContext<'a, 'tcx> {
             }
             ty::Ref(_, ty::TyS { sty: ty::Adt(adt_def, _), .. }, _)
             if !self.tcx.has_attr(adt_def.did, "structural_match") => {
+                // HACK(estebank): Side-step ICE #53708, but anything other than erroring here
+                // would be wrong. Returnging `PatternKind::Wild` is not technically correct.
                 let path = self.tcx.def_path_str(adt_def.did);
                 let msg = format!(
                     "to use a constant of type `{}` in a pattern, \

Original file line number	Diff line number	Diff line change
`@@ -986,6 +986,8 @@ impl<'a, 'tcx> PatternContext<'a, 'tcx> {`
`986`	`986`	`}`
`987`	`987`	`ty::Ref(_, ty::TyS { sty: ty::Adt(adt_def, _), .. }, _)`
`988`	`988`	`if !self.tcx.has_attr(adt_def.did, "structural_match") => {`
	`989`	`+ // HACK(estebank): Side-step ICE #53708, but anything other than erroring here`
	`990`	+ // would be wrong. Returnging `PatternKind::Wild` is not technically correct.
`989`	`991`	`let path = self.tcx.def_path_str(adt_def.did);`
`990`	`992`	`let msg = format!(`
`991`	`993`	"to use a constant of type `{}` in a pattern, \