Skip to content

Commit 87faa21

Browse files
committed
rustdoc: remove unused 16x16 favicon
According to <https://caniuse.com/?search=svg%20favicon>, SVG favicons are supported in everything but Safari. When I actually try it in Safari, it's downloading all three favicons, and nothing looks different when I disable the 16x16 one. <https://dev.to/masakudamatsu/favicon-nightmare-how-to-maintain-sanity-3al7>, which is linked from caniuse above, recommends an ico. However, the reason they recommend it is the apps that only support /favicon.ico exactly, and rustdoc can't assume it will be installed to the site root, so it's unfortunately up to the webmaster to make sure it's set up.
1 parent 13235dc commit 87faa21

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed
-715 Bytes
Binary file not shown.

src/librustdoc/html/static_files.rs

-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,6 @@ static_files! {
106106
license_mit => "static/LICENSE-MIT.txt",
107107
rust_logo_svg => "static/images/rust-logo.svg",
108108
rust_favicon_svg => "static/images/favicon.svg",
109-
rust_favicon_png_16 => "static/images/favicon-16x16.png",
110109
rust_favicon_png_32 => "static/images/favicon-32x32.png",
111110
fira_sans_regular => "static/fonts/FiraSans-Regular.woff2",
112111
fira_sans_medium => "static/fonts/FiraSans-Medium.woff2",

src/librustdoc/html/templates/page.html

-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@
5858
{% if !layout.favicon.is_empty() %}
5959
<link rel="icon" href="{{layout.favicon}}"> {# #}
6060
{% else %}
61-
<link rel="alternate icon" type="image/png" {#+ #}
62-
href="{{static_root_path|safe}}{{files.rust_favicon_png_16}}"> {# #}
6361
<link rel="alternate icon" type="image/png" {#+ #}
6462
href="{{static_root_path|safe}}{{files.rust_favicon_png_32}}"> {# #}
6563
<link rel="icon" type="image/svg+xml" {#+ #}

0 commit comments

Comments
 (0)