Skip to content

Commit 92f1cfd

Browse files
authored
Rollup merge of #61134 - nvzqz:reverse_bits-must_use, r=varkor
Annotate each `reverse_bits` with `#[must_use]` Because the name sounds like an in-place mutation like `[T]::reverse(&mut self)`, it may be confused for one. This change was requested at #48763 (comment).
2 parents 98052b0 + 035f651 commit 92f1cfd

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

src/libcore/num/mod.rs

+2
Original file line numberDiff line numberDiff line change
@@ -473,6 +473,7 @@ assert_eq!(m, ", $reversed, ");
473473
#[unstable(feature = "reverse_bits", issue = "48763")]
474474
#[rustc_const_unstable(feature = "const_int_conversion")]
475475
#[inline]
476+
#[must_use]
476477
pub const fn reverse_bits(self) -> Self {
477478
(self as $UnsignedT).reverse_bits() as Self
478479
}
@@ -2522,6 +2523,7 @@ assert_eq!(m, ", $reversed, ");
25222523
```"),
25232524
#[unstable(feature = "reverse_bits", issue = "48763")]
25242525
#[inline]
2526+
#[must_use]
25252527
pub const fn reverse_bits(self) -> Self {
25262528
intrinsics::bitreverse(self as $ActualT) as Self
25272529
}

src/libcore/num/wrapping.rs

+1
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,7 @@ assert_eq!(n.trailing_zeros(), 3);
524524
/// ```
525525
#[unstable(feature = "reverse_bits", issue = "48763")]
526526
#[inline]
527+
#[must_use]
527528
pub const fn reverse_bits(self) -> Self {
528529
Wrapping(self.0.reverse_bits())
529530
}

0 commit comments

Comments
 (0)