Add FIXME to comment regarding local patterns

doctorn · lcnr · web-flow · commit b4ddd9183103 · 2020-06-05T12:44:56.000+01:00
Co-authored-by: Bastian Kauschke &lt;bastian_kauschke@hotmail.de&gt;
diff --git a/src/librustc_infer/infer/error_reporting/need_type_info.rs b/src/librustc_infer/infer/error_reporting/need_type_info.rs
@@ -88,7 +88,7 @@ impl<'a, 'tcx> Visitor<'tcx> for FindHirNodeVisitor<'a, 'tcx> {
         if let (None, Some(ty)) =
             (self.found_local_pattern, self.node_ty_contains_target(local.hir_id))
         {
-            // There's a trade-off here - we can either check that our target span
+            // FIXME: There's a trade-off here - we can either check that our target span
             // is contained in `local.span` or not. If we choose to check containment
             // we can avoid some spurious suggestions (see #72690), but we lose
             // the ability to report on things like:

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ impl<'a, 'tcx> Visitor<'tcx> for FindHirNodeVisitor<'a, 'tcx> {`
`88`	`88`	`if let (None, Some(ty)) =`
`89`	`89`	`(self.found_local_pattern, self.node_ty_contains_target(local.hir_id))`
`90`	`90`	`{`
`91`		`- // There's a trade-off here - we can either check that our target span`
	`91`	`+ // FIXME: There's a trade-off here - we can either check that our target span`
`92`	`92`	// is contained in `local.span` or not. If we choose to check containment
`93`	`93`	`// we can avoid some spurious suggestions (see #72690), but we lose`
`94`	`94`	`// the ability to report on things like:`