Skip to content

Commit f1a7780

Browse files
committed
Auto merge of #117018 - Kobzol:opt-dist-cargo-stage0, r=<try>
Use beta cargo in opt-dist Using the new stage2 cargo caused issues when a backwards-incompatible change was made to cargo. This means that we won't be testing the LTO/1-CGU optimized cargo, but I don't think that's a big issue, as we primarily want to test the compiler. Should fix [this](#117000 (comment)) failure.
2 parents 6f97d83 + 9a07348 commit f1a7780

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

.github/workflows/ci.yml

-1
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,6 @@ jobs:
527527
try:
528528
name: "try - ${{ matrix.name }}"
529529
env:
530-
DIST_TRY_BUILD: 1
531530
CI_JOB_NAME: "${{ matrix.name }}"
532531
CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
533532
HEAD_SHA: "${{ github.event.pull_request.head.sha || github.sha }}"

src/ci/github-actions/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ jobs:
687687
<<: *base-ci-job
688688
name: try - ${{ matrix.name }}
689689
env:
690-
DIST_TRY_BUILD: 1
690+
# DIST_TRY_BUILD: 1
691691
<<: [*shared-ci-variables, *prod-variables]
692692
if: github.event_name == 'push' && (((github.ref == 'refs/heads/try' || github.ref == 'refs/heads/try-perf') && github.repository == 'rust-lang-ci/rust') || ((github.ref == 'refs/heads/automation/bors/try') && github.repository == 'rust-lang/rust'))
693693
strategy:

src/tools/opt-dist/src/tests.rs

+1-6
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,10 @@ pub fn run_tests(env: &Environment) -> anyhow::Result<()> {
2424
let host_triple = env.host_triple();
2525
let version = find_dist_version(&dist_dir)?;
2626

27-
// Extract rustc, libstd, cargo and src archives to create the optimized sysroot
27+
// Extract rustc, libstd and src archives to create the optimized sysroot
2828
let rustc_dir = extract_dist_dir(&format!("rustc-{version}-{host_triple}"))?.join("rustc");
2929
let libstd_dir = extract_dist_dir(&format!("rust-std-{version}-{host_triple}"))?
3030
.join(format!("rust-std-{host_triple}"));
31-
let cargo_dir = extract_dist_dir(&format!("cargo-{version}-{host_triple}"))?.join("cargo");
3231
let extracted_src_dir = extract_dist_dir(&format!("rust-src-{version}"))?.join("rust-src");
3332

3433
// We need to manually copy libstd to the extracted rustc sysroot
@@ -47,8 +46,6 @@ pub fn run_tests(env: &Environment) -> anyhow::Result<()> {
4746

4847
let rustc_path = rustc_dir.join("bin").join(format!("rustc{}", executable_extension()));
4948
assert!(rustc_path.is_file());
50-
let cargo_path = cargo_dir.join("bin").join(format!("cargo{}", executable_extension()));
51-
assert!(cargo_path.is_file());
5249

5350
// Specify path to a LLVM config so that LLVM is not rebuilt.
5451
// It doesn't really matter which LLVM config we choose, because no sysroot will be compiled.
@@ -65,13 +62,11 @@ change-id = 115898
6562
6663
[build]
6764
rustc = "{rustc}"
68-
cargo = "{cargo}"
6965
7066
[target.{host_triple}]
7167
llvm-config = "{llvm_config}"
7268
"#,
7369
rustc = rustc_path.to_string().replace('\\', "/"),
74-
cargo = cargo_path.to_string().replace('\\', "/"),
7570
llvm_config = llvm_config.to_string().replace('\\', "/")
7671
);
7772
log::info!("Using following `config.toml` for running tests:\n{config_content}");

0 commit comments

Comments
 (0)