Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a custom diagnostic for type mismatches of constants #125548

Closed
oli-obk opened this issue May 25, 2024 · 1 comment
Closed

add a custom diagnostic for type mismatches of constants #125548

oli-obk opened this issue May 25, 2024 · 1 comment
Assignees
@oli-obk
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@oli-obk
Copy link
Contributor

oli-obk commented May 25, 2024

Diagnostics changes here are meh, but I think we should fix those on the diagnostics side. Maybe we can relate a different TypeError kind for const kind mismatches that signal something is wrong in the source.

Originally posted by compiler-errors in #125451 (review)

The new diagnostic should specifically talk about the fact that the constants have different types
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 25, 2024
@oli-obk oli-obk self-assigned this May 25, 2024
@oli-obk oli-obk added A-diagnostics Area: Messages for errors, warnings, and lints and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 25, 2024
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 22, 2025

resolved by #125671 and follow-ups

@oli-obk oli-obk closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oli-obk @rustbot