Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable book lang_items example is outdated #136290

Open
cyrgani opened this issue Jan 30, 2025 · 1 comment
Open

Unstable book lang_items example is outdated #136290

cyrgani opened this issue Jan 30, 2025 · 1 comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-lang-item Area: Language items T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@cyrgani
Copy link
Contributor

cyrgani commented Jan 30, 2025

Location

https://github.com/rust-lang/rust/blob/master/src/doc/unstable-book/src/language-features/lang-items.md

Summary

The example uses #[rustc_box], which was removed in #135046. Unfortunately, the new intrinsic is at alloc::boxed::box_new and adding extern crate alloc to use it causes the real Box to conflict with the custom Box.

@rustbot label A-lang-item
@cyrgani cyrgani added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jan 30, 2025
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-lang-item Area: Language items labels Jan 30, 2025
@Noratrieb
Copy link
Member

This page should probably be deleted from the unstable book and added to the rustc dev guide

@Noratrieb Noratrieb added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-lang-item Area: Language items T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rustbot @Noratrieb @cyrgani