Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type inference of integer literals: inconsistency with the reference #41060

Closed
jaystrictor opened this issue Apr 4, 2017 · 1 comment
Closed
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-inference Area: Type inference C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@jaystrictor
Copy link
Contributor

The reference currently says the following for integer literals

The type of an unsuffixed integer literal is determined by type inference:
[...]
If the program context under-constrains the type, it defaults to the signed 32-bit integer i32.

This does however not work for some inherent methods of signed integer types:

trait A {
    fn what_type(&self);
}


impl A for i16 {
    fn what_type(&self) {
        println!("i16");
    }
}

impl A for i32 {
    fn what_type(&self)  {
        println!("i32");
    }
}

fn main() {
    let z = 1;
    z.what_type();
    //z.is_positive(); // <- uncomment this line
}

As you can see, z is under-constrained in this case. The compiler does the right thing and defaults to type i32, so calling the trait method what_type() works.

If you uncomment the inherent method call to is_positive(), z still is under-constrained in pretty much the same way as before, however, the compiler fails to default to i32 and instead prints

error: no method named `is_positive` found for type `{integer}` in the current scope

Also note that the reference says

If an integer type can be uniquely determined from the surrounding program context, the unsuffixed integer literal has that type.

But the following example show that the order of statements is important:

fn one() { // compiles
    let a = 0;
    take_some(a);
    a.is_positive();
}

fn two() { // does not compile
    let a = 0;
    a.is_positive();
    take_some(a);
}

fn take_some(var: i32) {
    // do nothing
}

I think floating-point literals have the same issue, but I haven't checked.

Issue #39255 and issue #40985 may be related.

@Mark-Simulacrum Mark-Simulacrum added the A-inference Area: Type inference label May 20, 2017
@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Jul 27, 2017
@steveklabnik
Copy link
Member

i've moved this over to rust-lang/reference#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-inference Area: Type inference C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

3 participants