Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unic-idna-mapping-0.4.0 beta regression #43683

Closed
est31 opened this issue Aug 5, 2017 · 5 comments
Closed

unic-idna-mapping-0.4.0 beta regression #43683

est31 opened this issue Aug 5, 2017 · 5 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

unic-idna-mapping version 0.4.0 regressed from stable to beta (full log):

Aug 04 02:28:56.746 INFO kablam! error[E0560]: struct `__test::test::TestDesc` has no field named `allow_fail`
Aug 04 02:28:56.746 INFO kablam!   --> tests/unicode_version_tests.rs:17:1
Aug 04 02:28:56.746 INFO kablam!    |
Aug 04 02:28:56.746 INFO kablam! 17 | / fn test_version_against_ucd_core() {
Aug 04 02:28:56.746 INFO kablam! 18 | |     assert_eq!(
Aug 04 02:28:56.746 INFO kablam! 19 | |         unic_ucd_core::UNICODE_VERSION,
Aug 04 02:28:56.746 INFO kablam! 20 | |         unic_idna_mapping::UNICODE_VERSION
Aug 04 02:28:56.746 INFO kablam! 21 | |     );
Aug 04 02:28:56.746 INFO kablam! 22 | | }
Aug 04 02:28:56.746 INFO kablam!    | |_^ `__test::test::TestDesc` does not have this field

cc @behnam

@arielb1 arielb1 added I-nominated regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

what?

@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

Looks like a dupe of #43684 - rustc_test is being used.

@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

@alexcrichton
Copy link
Member

Closing in favor of #43684

@behnam
Copy link
Contributor

behnam commented Aug 5, 2017

Thanks, @est31, for the report. Yes, it is a known problem that we need to maintain rustc_test for the beta/nightly to pass. For UNIC specifically, we want to drop the dependency and use an approach that works also on stable, with some extra goodies. Here's the issue I filed: open-i18n/rust-unic#76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants