Duration::as_msecs(), as_microsecs(), as_nanosecs()

[Boscop]

I often find myself needing this extension to std's Duration, why isn't something like this part of std? :)

pub trait DurationExt {
	fn as_msecs(&self) -> u64;
	fn as_microsecs(&self) -> u64;
	fn as_nanosecs(&self) -> u64;
}

impl DurationExt for Duration {
	fn as_msecs(&self) -> u64 {
		self.as_secs() * 1_000 + (self.subsec_nanos() as f64 / 1_000_000.0).round() as u64
	}
	fn as_microsecs(&self) -> u64 {
		self.as_secs() * 1_000_000 + (self.subsec_nanos() as f64 / 1_000.0).round() as u64
	}
	fn as_nanosecs(&self) -> u64 {
		self.as_secs() * 1_000_000_000 + self.subsec_nanos() as u64
	}
}

[hellow554]

You may get a problem with this.
Because you can use a u64 for seconds you can overflow as_msecs by using u64::max_value() and then you would cause an overflow/panic/destroy of the universe.
I guess, that's why there is subsec_millis to avoid this problem (which was btw. merged 8 days ago :) )

[est31]

#50202 #50167

[rossmacarthur]

It appears this can be closed?

https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_millis
https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_micros
https://doc.rust-lang.org/std/time/struct.Duration.html#method.as_nanos