You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
span_note and friends require this non-obvious pattern to work correctly:
if span.is_dummy(){
err.note(msg);}else{
err.span_note(span, msg);}
If dummy span is passed to span_note then the message simply won't be displayed, but with note it will be attached to the primary err message.
The difference is that note turns into an empty multi-span, but span_note turns into multi-span containing a single dummy span.
I think span_note should "just work" with dummy spans and display the message equivalently to note.
The text was updated successfully, but these errors were encountered:
Now multispans also have an is_dummy() method, so that won't be a source of problems. The only thing that I can think of that could present a challenge is for suggestions (which I guess are out of scope for this thicket) they usually have a fallback with tweaked wording to work as note/help.
span_note
and friends require this non-obvious pattern to work correctly:If dummy span is passed to
span_note
then the message simply won't be displayed, but withnote
it will be attached to the primaryerr
message.The difference is that
note
turns into an empty multi-span, butspan_note
turns into multi-span containing a single dummy span.I think
span_note
should "just work" with dummy spans and display the message equivalently tonote
.The text was updated successfully, but these errors were encountered: