Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add winapi (or variant thereof) as benchmark to perf.rust-lang.org #70394

Closed
pnkfelix opened this issue Mar 25, 2020 · 2 comments
Closed

Add winapi (or variant thereof) as benchmark to perf.rust-lang.org #70394

pnkfelix opened this issue Mar 25, 2020 · 2 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

Spawned off of #48247

There have been instances where we have injected performance issues when compiling winapi

It has been suggested that we add winapi as a standard benchmark.

(In general I would like to revisit our benchmarks as a whole, which I guess is a task covered by #48750.)

This issue is more targeted: We should add winapi, or a variant that captures its workload but works on Linux hosts, to the set of rustc benchmarks that live on perf.rust-lang.org.

@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2020
@retep998
Copy link
Member

A similar issue exists here: rust-lang/rustc-perf#181

@Mark-Simulacrum
Copy link
Member

Seems reasonable to track this just on rustc-perf for now, so going to close this in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants