Skip to content

rustpkg fails to inject a link name if other linkage attributes are present #9175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Sep 13, 2013 · 2 comments
Closed

rustpkg fails to inject a link name if other linkage attributes are present #9175

catamorphism opened this issue Sep 13, 2013 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@catamorphism
Copy link
Contributor

If you compile:

#[link(vers = "3.1415927)]
fn main() {}

with rustpkg, rustc will complain about a missing link name. This is because if any linkage attributes are present, rustpkg doesn't inject a link name based on the package ID. That's incorrect; it should inject a link name if no link name was specified (or possibly always, given #8523).

Spotted by @metajack
@ghost ghost assigned catamorphism Sep 13, 2013
@luisbg
Copy link
Contributor

luisbg commented Sep 18, 2013

I can't reproduce this.

@darnuria
Copy link
Contributor

Sure to keep this bug up as rustpkg is "deprecated" at the moment?

@catamorphism catamorphism removed their assignment Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luisbg @catamorphism @thestinger @darnuria