Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to top-level config.toml if not present in current directory #94589

Closed
jyn514 opened this issue Mar 4, 2022 · 1 comment · Fixed by #94592
Closed

Fallback to top-level config.toml if not present in current directory #94589

jyn514 opened this issue Mar 4, 2022 · 1 comment · Fixed by #94592
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 4, 2022

Currently x.py has some very strange behavior around config.toml.

We should make these consistent and fall back to the root directory for the default path as well. @pnkfelix has mentioned in the past they use per-directory config.toml files, but this wouldn't break that workflow - the only thing that would change is that "switch to a new directory to get a blank build + config" would have to also run touch config.toml.

cc @Mark-Simulacrum
@rustbot label: +A-rustbuild +C-enhancement

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Mar 4, 2022
@jyn514
Copy link
Member Author

jyn514 commented Mar 4, 2022

While writing this up I realized that #92260 is missing the root dir fallback for the flag and env variable; but given that it only affects the new cargo run workflow and I doubt the fallback is used much in practice, it's probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
2 participants