Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of rustc_codegen_utils breaks mdbook builds #628

Closed
chrissimpkins opened this issue Mar 22, 2020 · 3 comments · Fixed by #630
Closed

Removal of rustc_codegen_utils breaks mdbook builds #628

chrissimpkins opened this issue Mar 22, 2020 · 3 comments · Fixed by #630

Comments

@chrissimpkins
Copy link
Member

It looks like the merge of rust-lang/rust#69965 led to mdbook build fails on Travis: https://travis-ci.com/github/rust-lang/rustc-dev-guide/builds/154502721#L342

It is due to this link to the librustc_codegen_utils docs in appendix/stupid-stats.md:

> NOTE: `librustc_trans` and `librustc_back` no longer exist, and we don't
> translate AST or HIR directly to LLVM IR anymore.  Instead, see
> [`librustc_codegen_llvm`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/index.html)
> and [`librustc_codegen_utils`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_utils/index.html).

The https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_utils/index.html URL lands on a 404 page. Should it be removed or is there an updated location that still pertains here?

@mark-i-m
Copy link
Member

@chrissimpkins librustc_codgen_utils has been dissolved into a bunch of places. It probably makes more sense to point to librustc_codegen_ssa and librustc_codegen_llvm.

@chrissimpkins
Copy link
Member Author

I'll push a PR with the updates shortly. Thanks Mark.

@chrissimpkins
Copy link
Member Author

#630 should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants