Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nightlies are at risk of tripping File too big #1982

Closed
kinnison opened this issue Sep 4, 2019 · 0 comments
Closed

New nightlies are at risk of tripping File too big #1982

kinnison opened this issue Sep 4, 2019 · 0 comments
Assignees
Labels

Comments

@kinnison
Copy link
Contributor

kinnison commented Sep 4, 2019

As seen in #1970 (comment) we are now generating nightlies which have 170M rlibs in.

Our multithreaded unpacker assumes each thread won't deal with files > 100M and thus limits its RAM usage by number of threads. We now seem to have files much larger than that and so we might need to up the limit at https://github.com/rust-lang/rustup.rs/blob/master/src/dist/component/package.rs#L280 and check associated numbers to re-trim things.

/cc @rbtcollins Opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant