Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI with -Z randomize-layout #28

Open
Tracked by #37
xFrednet opened this issue Aug 2, 2022 · 0 comments
Open
Tracked by #37

Add CI with -Z randomize-layout #28

xFrednet opened this issue Aug 2, 2022 · 0 comments
Labels
A-infra Area: Infrastructure and CI magic :sparkles: C-enhancement Category: New feature or request

Comments

@xFrednet
Copy link
Member

xFrednet commented Aug 2, 2022

Almost all communication between the linter driver and lint-crates requires the exchange of information. For rust-marker, this is done with marker_api types. Special care needs to be taken, since Rust doesn't have a stable ABI. To ensure that this is done correctly, I would like to see a CI step that uses the -Z randomize-layout flag.

It should be checked, that the -Z randomize-layout is also passed on by cargo-marker which compiles the driver and lint crates


I imagine something like running this on linux (Since those are the fastest GH runners), and start the test suite two or three times with random layouts. Just running it once might not catch all invalid instances. When we have more tests, the test suite can be reduced to a small subset. It will most likely also be enough if this is run as part of bors tests, just to not waste GH runner time more than needed.

@xFrednet xFrednet added A-infra Area: Infrastructure and CI magic :sparkles: C-enhancement Category: New feature or request labels Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-infra Area: Infrastructure and CI magic :sparkles: C-enhancement Category: New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant