You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Almost all communication between the linter driver and lint-crates requires the exchange of information. For rust-marker, this is done with marker_api types. Special care needs to be taken, since Rust doesn't have a stable ABI. To ensure that this is done correctly, I would like to see a CI step that uses the -Z randomize-layout flag.
It should be checked, that the -Z randomize-layout is also passed on by cargo-marker which compiles the driver and lint crates
I imagine something like running this on linux (Since those are the fastest GH runners), and start the test suite two or three times with random layouts. Just running it once might not catch all invalid instances. When we have more tests, the test suite can be reduced to a small subset. It will most likely also be enough if this is run as part of bors tests, just to not waste GH runner time more than needed.
The text was updated successfully, but these errors were encountered:
Almost all communication between the linter driver and lint-crates requires the exchange of information. For rust-marker, this is done with
marker_api
types. Special care needs to be taken, since Rust doesn't have a stable ABI. To ensure that this is done correctly, I would like to see a CI step that uses the-Z randomize-layout
flag.It should be checked, that the
-Z randomize-layout
is also passed on bycargo-marker
which compiles the driver and lint cratesI imagine something like running this on linux (Since those are the fastest GH runners), and start the test suite two or three times with random layouts. Just running it once might not catch all invalid instances. When we have more tests, the test suite can be reduced to a small subset. It will most likely also be enough if this is run as part of bors tests, just to not waste GH runner time more than needed.
The text was updated successfully, but these errors were encountered: