Skip to content

Commit 3e2bc00

Browse files
committed
Example: eg/servo-diagnostic.js simplified
1 parent 2ce0505 commit 3e2bc00

File tree

1 file changed

+6
-21
lines changed

1 file changed

+6
-21
lines changed

eg/servo-diagnostic.js

+6-21
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const {Board, Servo, Servos} = require("../lib/johnny-five.js");
1+
// const {Board, Servo, Servos} = require("../lib/johnny-five.js");
22

33
/**
44
* This program is useful for manual servo administration.
@@ -18,32 +18,17 @@ const {Board, Servo, Servos} = require("../lib/johnny-five.js");
1818
*/
1919

2020
const args = process.argv.slice(2);
21-
let pins = [];
22-
let ranges = [];
23-
24-
args.forEach(val => {
25-
const vals = val.split(":").map(Number);
26-
27-
pins.push(vals[0]);
28-
29-
ranges.push(
30-
vals.length === 3 ?
31-
vals.slice(1) : [0, 180]
32-
);
21+
const configs = args.map(val => {
22+
const [pin, min = 0, max = 180] = val.split(":").map(Number);
23+
const range = [min, max];
24+
return {pin, range};
3325
});
3426

3527
const board = new Board();
3628

3729
board.on("ready", () => {
3830
// With each provided pin number, create a servo instance
39-
pins.forEach((pin, k) => {
40-
new Servo({
41-
pin,
42-
range: ranges[k]
43-
});
44-
});
45-
46-
const servos = new Servos();
31+
const servos = new Servos(configs);
4732

4833
servos.center();
4934

0 commit comments

Comments
 (0)