Skip to content

Commit edd6a58

Browse files
committed
test: rename test-regress-nodejsGH-4256
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure
1 parent 3dd9688 commit edd6a58

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

test/parallel/test-regress-GH-4256.js test/parallel/test-process-domain-segfault.js

+5
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@
2121

2222
'use strict';
2323
require('../common');
24+
25+
// This test ensures that setting `process.domain` to `null` does not result in
26+
// node crashing with a segfault
27+
// https://github.com/nodejs/node-v0.x-archive/issues/4256
28+
2429
process.domain = null;
2530
setTimeout(function() {
2631
console.log('this console.log statement should not make node crash');

0 commit comments

Comments
 (0)