fix rst and codespell

Author: fchapoton

sage_patchbot/http_post_file.py

@@ -42,9 +42,10 @@ def by(utf_string: str) -> bytes:
 
 
 def encode_multipart_formdata(fields, files):
-    """
-    fields is a sequence of (name, value) elements for regular form
-    fields.  files is a sequence of (name, filename, value) elements
+    r"""
+    fields is a sequence of (name, value) elements for regular form fields.
+
+    files is a sequence of (name, filename, value) elements
     for data to be uploaded as files
 
     Return (content_type, body) ready for httplib.HTTP instance
@@ -54,7 +55,7 @@ def encode_multipart_formdata(fields, files):
         In [2]: encode_multipart_formdata([],[])
         Out[2]:
         ('multipart/form-data; boundary=JPS2ZAVEEIQZW6K5JVQB1IJE2W',
-         '--JPS2ZAVEEIQZW6K5JVQB1IJE2W--\r\n')
+        '--JPS2ZAVEEIQZW6K5JVQB1IJE2W--\r\n')
     """
     # BOUNDARY = mimetools.choose_boundary()
     UTF_BOUNDARY = id_generator()
@@ -71,7 +72,8 @@ def encode_multipart_formdata(fields, files):
         L.append(by(value))
     for (key, filename, value) in files:
         L.append(dd + BOUNDARY)
-        cont = f'Content-Disposition: form-data; name="{key}"; filename="{filename}"'
+        cont = 'Content-Disposition: form-data; '
+        cont += f'name="{key}"; filename="{filename}"'
         L.append(by(cont))
         L.append(by(f'Content-Type: {get_content_type(filename)}'))
         L.append(by(''))

sage_patchbot/patchbot.py

@@ -809,8 +809,8 @@ def rate_ticket(self, ticket, verbose=False):
                 self.write_log('#{}: no git branch'.format(ticket['id']), logfile)
                 return
 
-            if not(ticket['status'] in ('needs_review', 'positive_review',
-                                        'needs_info', 'needs_work')):
+            if ticket['status'] not in ('needs_review', 'positive_review',
+                                        'needs_info', 'needs_work'):
                 msg = '#{}: bad status (={})'
                 self.write_log(msg.format(ticket['id'],
                                           ticket['status']), logfile)
@@ -996,7 +996,7 @@ def test_a_ticket(self, ticket=None):
             self.write_log("warning: rating is None, testing #{} at your own risk".format(ticket['id']),
                            LOG_MAIN)
 
-        if not(ticket.get('git_branch') or ticket['id'] == 0):
+        if not (ticket.get('git_branch') or ticket['id'] == 0):
             self.write_log("no git branch for #{}, hence no testing".format(ticket['id']),
                            LOG_MAIN)
             return
@@ -1044,7 +1044,7 @@ def test_a_ticket(self, ticket=None):
                     self.to_skip[ticket['id']] = time.time() + 240 * 60 * 60
 
                 is_ci_only = False  # branch_updates_only_ci()
-                # desactivated for now
+                # not activated for now
 
                 if not is_spkg and not is_ci_only:
                     # ------------- make -------------

sage_patchbot/plugins.py

@@ -587,19 +587,19 @@ def doctest_continuation(ticket, **kwds):
 
 def blocks(ticket, **kwds):
     """
-    some check for the blocks
+    some check for the blocks:
 
-    1) correct syntax is .. SEEALSO::
+    1) correct syntax is ``.. SEEALSO::``
 
-    2) TESTS and EXAMPLES should be plural, NOTE singular
+    2) ``TESTS`` and ``EXAMPLES`` should be plural, ``NOTE`` singular
 
-    3) no :: after INPUT and OUTPUT blocks
+    3) no ``::`` after ``INPUT`` and ``OUTPUT`` blocks
 
-    4) no :: after REFERENCE blocks
+    4) no ``::`` after ``REFERENCE`` blocks
 
-    5) no " :" at the end of lines
+    5) no `` :`` at the end of lines
 
-    6) no "Returns" at the start of lines
+    6) no ``Returns`` at the start of lines
     """
     regexps = [r'\.\.SEE|SEE ALSO|SEEALSO:($|[^:])',
                r'^\s*TEST:', r'^\s*EXAMPLE:', r'^\s*NOTES:',