Skip to content

Commit 2f2ed01

Browse files
author
Release Manager
committed
gh-35098: sage.{topology,homology}: Replace imports from sage.*.all for namespace packages <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> Fixes #34953 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: #35098 Reported by: Matthias Köppe Reviewer(s):
2 parents cc3da36 + 8a6bfef commit 2f2ed01

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/sage/homology/chain_complex.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@
6262
from sage.matrix.constructor import matrix
6363
from sage.misc.latex import latex
6464
from sage.misc.superseded import deprecation
65-
from sage.rings.all import GF, prime_range
65+
from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
66+
from sage.rings.fast_arith import prime_range
6667
from sage.homology.homology_group import HomologyGroup
6768

6869

src/sage/homology/koszul_complex.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from sage.structure.unique_representation import UniqueRepresentation
1515
from sage.structure.parent import Parent
1616
from sage.combinat.combination import rank
17-
from sage.arith.all import binomial
17+
from sage.arith.misc import binomial
1818
from sage.rings.integer_ring import ZZ
1919
from sage.matrix.constructor import matrix
2020
from sage.homology.chain_complex import ChainComplex_class

src/sage/topology/delta_complex.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
from .simplicial_complex import Simplex, lattice_paths, SimplicialComplex
6060
from sage.homology.chain_complex import ChainComplex
6161
from sage.graphs.graph import Graph
62-
from sage.arith.all import binomial
62+
from sage.arith.misc import binomial
6363
from sage.misc.cachefunc import cached_method
6464

6565

src/sage/topology/simplicial_complex.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1452,7 +1452,7 @@ def h_vector(self):
14521452
sage: octa.h_vector()
14531453
[1, 3, 3, 1]
14541454
"""
1455-
from sage.arith.all import binomial
1455+
from sage.arith.misc import binomial
14561456
d = self.dimension()
14571457
f = self.f_vector() # indexed starting at 0, since it's a Python list
14581458
h = []
@@ -1573,7 +1573,7 @@ def h_triangle(self):
15731573
[0, 0, 4],
15741574
[1, 2, -1, 0]]
15751575
"""
1576-
from sage.arith.all import binomial
1576+
from sage.arith.misc import binomial
15771577
ret = [[0]*(i+1) for i in range(self.dimension() + 2)]
15781578
f = self.f_triangle()
15791579
for i, row in enumerate(ret):

0 commit comments

Comments
 (0)