Skip to content

Commit 80511e1

Browse files
author
Release Manager
committed
gh-35110: Meta-PR: Replace imports from sage.*.all for namespace packages <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Fixes #34201 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> - Depends on #35090 - Depends on #35098 - Depends on #35099 - Depends on #35105 - Depends on #35106 - Depends on #35107 URL: #35110 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
2 parents eaf6393 + 34586ac commit 80511e1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/.relint.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@
5050
Hint: or use 'sage --fiximports' to fix automatically in the source file.
5151
# Keep in sync with SAGE_ROOT/src/sage/misc/replace_dot_all.py
5252
pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings(|[.]finite_rings)|sets))[.]all\s+import'
53-
filePattern: '.*[.](py|pyx|pxi)$'
54-
error: false # Make this a warning instead of an error for now
53+
# imports from .all are allowed in all.py; also allow in some modules that need sage.all
54+
filePattern: '(.*/|)(?!(all|benchmark|dev_tools|parsing|sage_eval))[^/.]*[.](py|pyx|pxi)$'

src/sage/rings/polynomial/integer_valued_polynomials.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
# https://www.gnu.org/licenses/
1414
# ***************************************************************************
1515
from sage.arith.misc import (binomial, factorial)
16+
from sage.categories.algebras import Algebras
1617
from sage.categories.rings import Rings
17-
from sage.categories.all import Algebras
1818
from sage.categories.realizations import Category_realization_of_parent
1919
from sage.combinat.free_module import CombinatorialFreeModule
2020
from sage.matrix.constructor import matrix

0 commit comments

Comments
 (0)