Trac #26759: remove a big bunch of deprecated stuff

after #22755, #22632, #22630, #22129, #22805, #22311, #22470

URL: https://trac.sagemath.org/26759
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

Author: Release Manager

src/sage/arith/functions.pyx

@@ -2,15 +2,15 @@
 Fast Arithmetic Functions
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2017 Travis Scrimshaw <tcscrims at gmail.com>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 2 of the License, or
 # (at your option) any later version.
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 
 from cysignals.signals cimport sig_check
 
@@ -63,8 +63,8 @@ def lcm(a, b=None):
     The following shows that indeed coercion takes place before
     computing the least common multiple::
 
-        sage: R.<x>=QQ[]
-        sage: S.<x>=ZZ[]
+        sage: R.<x> = QQ[]
+        sage: S.<x> = ZZ[]
         sage: p = S.random_element(degree=(0,5))
         sage: q = R.random_element(degree=(0,5))
         sage: parent(lcm([1/p,q]))
@@ -115,7 +115,7 @@ def lcm(a, b=None):
 
     try:
         return a.lcm(b)
-    except (AttributeError,TypeError):
+    except (AttributeError, TypeError):
         pass
     try:
         return Integer(a).lcm(Integer(b))
@@ -186,13 +186,6 @@ cpdef LCM_list(v):
         sage: R.<X> = QQ[]
         sage: LCM_list(Sequence((2*X+4,2*X^2,2)))
         X^3 + 2*X^2
-
-    Passing strings works, but this is deprecated::
-
-        sage: LCM_list([int(3), int(9), '30'])
-        doctest:...: DeprecationWarning: passing strings to lcm() is deprecated
-        See http://trac.sagemath.org/22630 for details.
-        90
     """
     cdef Integer x
     cdef Integer z = <Integer>(Integer.__new__(Integer))
@@ -205,10 +198,6 @@ cpdef LCM_list(v):
             x = <Integer>elt
         elif isinstance(elt, (int, long)):
             x = Integer(elt)
-        elif isinstance(elt, str):
-            from sage.misc.superseded import deprecation
-            deprecation(22630, "passing strings to lcm() is deprecated")
-            x = Integer(elt)
         else:
             # The result is no longer an Integer, pass to generic code
             a, b = coercion_model.canonical_coercion(z, elt)

src/sage/combinat/free_module.py

@@ -1182,39 +1182,10 @@ def _from_dict(self, d, coerce=False, remove_zeros=True):
         assert isinstance(d, dict)
         if coerce:
             R = self.base_ring()
-            d = {key: R(coeff) for key,coeff in six.iteritems(d)}
+            d = {key: R(coeff) for key, coeff in six.iteritems(d)}
         if remove_zeros:
             d = {key: coeff for key, coeff in six.iteritems(d) if coeff}
-        return self.element_class( self, d )
-
-class CombinatorialFreeModuleElement(CombinatorialFreeModule.Element):
-    """
-    Deprecated. Use
-    :class:`sage.modules.with_basis.indexed_element.IndexedFreeModuleElement`
-    or :class:`CombinatorialFreeModule.Element` instead.
-    """
-    def __init__(self, *args, **kwds):
-        """
-        TESTS::
-
-            sage: from sage.combinat.free_module import CombinatorialFreeModuleElement
-            sage: class Test(CombinatorialFreeModule):
-            ....:     class Element(CombinatorialFreeModuleElement):
-            ....:         pass
-            sage: T = Test(QQ, (1,2))
-            sage: T.an_element()
-            doctest:warning
-            ...
-            DeprecationWarning: CombinatorialFreeModuleElement is deprecated.
-             Use IndexedFreeModuleElement or CombinatorialFreeModule.Element instead.
-            See http://trac.sagemath.org/22632 for details.
-            2*B[1] + 2*B[2]
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(22632, "CombinatorialFreeModuleElement is deprecated."
-                           " Use IndexedFreeModuleElement"
-                           " or CombinatorialFreeModule.Element instead.")
-        super(CombinatorialFreeModuleElement, self).__init__(*args, **kwds)
+        return self.element_class(self, d)
 
 
 class CombinatorialFreeModule_Tensor(CombinatorialFreeModule):

src/sage/groups/group.pyx

@@ -2,7 +2,7 @@
 Base class for groups
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2005 William Stein <[email protected]>
 #
 #  Distributed under the terms of the GNU General Public License (GPL)
@@ -14,8 +14,8 @@ Base class for groups
 #
 #  The full text of the GPL is available at:
 #
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 from __future__ import absolute_import
 
 import random
@@ -24,6 +24,7 @@ from sage.structure.parent cimport Parent
 from sage.rings.infinity import infinity
 from sage.rings.integer_ring import ZZ
 
+
 def is_Group(x):
     """
     Return whether ``x`` is a group object.
@@ -77,7 +78,7 @@ cdef class Group(Parent):
         ...
         NotImplementedError: cannot construct elements of <sage.groups.group.Group object at ...>
     """
-    def __init__(self, base=None, gens=None, category=None):
+    def __init__(self, base=None, category=None):
         """
         The Python constructor
 
@@ -105,9 +106,6 @@ cdef class Group(Parent):
             sage: h == hash(G)
             True
         """
-        if gens is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(22129, "gens keyword has been deprecated. Define a method gens() instead.")
         from sage.categories.groups import Groups
         if category is None:
             category = Groups()
@@ -262,7 +260,7 @@ cdef class FiniteGroup(Group):
     Generic finite group.
     """
 
-    def __init__(self, base=None, gens=None, category=None):
+    def __init__(self, base=None, category=None):
         """
         The Python constructor
 
@@ -273,22 +271,19 @@ cdef class FiniteGroup(Group):
             sage: G.category()
             Category of finite groups
         """
-        if gens is not None:
-            from sage.misc.superseded import deprecation
-            deprecation(22129, "gens keyword has been deprecated. Define a method gens() instead.")
         from sage.categories.finite_groups import FiniteGroups
         if category is None:
             category = FiniteGroups()
         else:
             if not isinstance(category, tuple):
                 category = (category,)
             if not any(cat.is_subcategory(FiniteGroups()) for cat in category):
-                raise ValueError("%s is not a subcategory of %s"%(category, FiniteGroups()))
+                raise ValueError("%s is not a subcategory of %s" % (category, FiniteGroups()))
         Parent.__init__(self, base=base, category=category)
 
     def is_finite(self):
         """
-        Return True.
+        Return ``True``.
 
         EXAMPLES::
 

src/sage/misc/cython.py

@@ -8,16 +8,15 @@
 - Martin Albrecht & William Stein (2011-08): cfile & cargs
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2006 William Stein <[email protected]>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 2 of the License, or
 # (at your option) any later version.
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
-
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 from __future__ import print_function, absolute_import
 from six.moves import builtins
 from six import iteritems
@@ -690,36 +689,6 @@ def cython(filename, verbose=0, compile_message=False,
     return name, target_dir
 
 
-def subtract_from_line_numbers(s, n):
-    r"""
-    Given a string ``s`` and an integer ``n``, for any line of ``s`` which has
-    the form ``'text:NUM:text'`` subtract ``n`` from NUM and return
-    ``'text:(NUM-n):text'``. Return other lines of ``s`` without change.
-
-    EXAMPLES::
-
-        sage: from sage.misc.cython import subtract_from_line_numbers
-        sage: subtract_from_line_numbers('hello:1234:hello', 3)
-        doctest:...: DeprecationWarning: subtract_from_line_numbers is deprecated
-        See http://trac.sagemath.org/22805 for details.
-        'hello:1231:hello\n'
-        sage: subtract_from_line_numbers('text:123\nhello:1234:', 3)
-        'text:123\nhello:1231:\n'
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(22805, 'subtract_from_line_numbers is deprecated')
-
-    ans = []
-    for X in s.split('\n'):
-        i = X.find(':')
-        j = i+1 + X[i+1:].find(':')
-        try:
-            ans.append('%s:%s:%s\n'%(X[:i], int(X[i+1:j]) - n, X[j+1:]))
-        except ValueError:
-            ans.append(X)
-    return '\n'.join(ans)
-
-
 ################################################################
 # COMPILE
 ################################################################

src/sage/misc/lazy_import.pyx

@@ -42,15 +42,15 @@ AUTHOR:
  - Robert Bradshaw
 """
 
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2009 Robert Bradshaw <[email protected]>
 #
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 2 of the License, or
 # (at your option) any later version.
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 
 # Keep OLD division semantics for Python 2 compatibility, such that
 # lazy imports support old and true division.
@@ -101,7 +101,7 @@ cpdef finish_startup():
 
 cpdef bint is_during_startup():
     """
-    Return whether Sage is currently starting up
+    Return whether Sage is currently starting up.
 
     OUTPUT:
 
@@ -283,7 +283,7 @@ cdef class LazyImport(object):
 
     def _sage_src_(self):
         """
-        Returns the source of the wrapped object for introspection.
+        Return the source of the wrapped object for introspection.
 
         EXAMPLES::
 
@@ -296,7 +296,7 @@ cdef class LazyImport(object):
 
     def _sage_argspec_(self):
         """
-        Returns the argspec of the wrapped object for introspection.
+        Return the argspec of the wrapped object for introspection.
 
         EXAMPLES::
 
@@ -975,7 +975,7 @@ cdef class LazyImport(object):
 
 
 def lazy_import(module, names, as_=None, *,
-    at_startup=False, namespace=None, overwrite=None, deprecation=None):
+    at_startup=False, namespace=None, deprecation=None):
     """
     Create a lazy import object and inject it into the caller's global
     namespace. For the purposes of introspection and calling, this is
@@ -1067,9 +1067,6 @@ def lazy_import(module, names, as_=None, *,
         See http://trac.sagemath.org/14275 for details.
         5-adic Field with capped relative precision 20
     """
-    if overwrite is not None:
-        from sage.misc.superseded import deprecation
-        deprecation(22755, "lazy_import(overwrite=False) is no longer supported")
     if as_ is None:
         as_ = names
     if isinstance(names, basestring):

src/sage/structure/element.pxd

@@ -144,27 +144,6 @@ cpdef inline bint have_same_parent(left, right):
     return HAVE_SAME_PARENT(classify_elements(left, right))
 
 
-cdef inline parent_c(x):
-    """
-    Deprecated alias for :func:`parent`.
-
-    TESTS::
-
-        sage: cython('''
-        ....: from sage.structure.element cimport parent_c
-        ....: from sage.all import ZZ
-        ....: print(parent_c(ZZ.one()))
-        ....: ''')
-        doctest:...:
-        DeprecationWarning: parent_c() is deprecated, use parent() instead
-        See http://trac.sagemath.org/22311 for details.
-        Integer Ring
-    """
-    from sage.misc.superseded import deprecation
-    deprecation(22311, "parent_c() is deprecated, use parent() instead")
-    return parent(x)
-
-
 cdef unary_op_exception(op, x)
 cdef bin_op_exception(op, x, y)
 

src/sage/structure/sage_object.pyx

@@ -690,24 +690,6 @@ cdef class SageObject:
     def _sage_(self):
         return self
 
-    def _pari_(self):
-        """
-        Deprecated alias for ``__pari__``.
-
-        TESTS::
-
-            sage: class NewStylePari(SageObject):
-            ....:     def __pari__(self):
-            ....:         return pari(42)
-            sage: NewStylePari()._pari_()
-            doctest:...: DeprecationWarning: the _pari_ method is deprecated, use __pari__ instead
-            See http://trac.sagemath.org/22470 for details.
-            42
-        """
-        from sage.misc.superseded import deprecation
-        deprecation(22470, 'the _pari_ method is deprecated, use __pari__ instead')
-        return self.__pari__()
-
     def _interface_(self, I):
         """
         Return coercion of self to an object of the interface I.