src/sage/schemes: Deprecate is_... functions

Author: Matthias Koeppe

src/sage/schemes/affine/affine_space.py

@@ -52,6 +52,8 @@ def is_AffineSpace(x) -> bool:
         sage: is_AffineSpace(Spec(ZZ))
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_AffineSpace is deprecated; use 'isinstance(..., AffineSpace_generic)' instead")
     return isinstance(x, AffineSpace_generic)
 
 

src/sage/schemes/berkovich/berkovich_space.py

@@ -62,6 +62,8 @@ def is_Berkovich(space) -> bool:
         sage: is_Berkovich(B)
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_Berkovich is deprecated; use 'isinstance(..., Berkovich)' instead")
     return isinstance(space, Berkovich)
 
 
@@ -81,6 +83,8 @@ def is_Berkovich_Cp(space) -> bool:
         sage: is_Berkovich(B)
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_Berkovich_Cp is deprecated; use 'isinstance(..., Berkovich_Cp)' instead")
     return isinstance(space, Berkovich_Cp)
 
 

src/sage/schemes/elliptic_curves/ell_generic.py

@@ -102,6 +102,8 @@ def is_EllipticCurve(x):
         sage: is_EllipticCurve(0)
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_EllipticCurve is deprecated; use 'isinstance(..., EllipticCurve_generic)' instead")
     return isinstance(x, EllipticCurve_generic)
 
 

src/sage/schemes/generic/algebraic_scheme.py

@@ -190,6 +190,8 @@ def is_AlgebraicScheme(x):
         sage: is_AlgebraicScheme(S)
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_AlgebraicScheme is deprecated; use 'isinstance(..., AlgebraicScheme)' instead")
     return isinstance(x, AlgebraicScheme)
 
 

src/sage/schemes/generic/ambient_space.py

@@ -32,8 +32,11 @@ def is_AmbientSpace(x):
         sage: is_AmbientSpace(P.subscheme([x + y + z]))
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_AmbientSpace is deprecated; use 'isinstance(..., AmbientSpace)' instead")
     return isinstance(x, AmbientSpace)
 
+
 class AmbientSpace(Scheme):
     """
     Base class for ambient spaces over a ring.

src/sage/schemes/generic/divisor_group.py

@@ -79,6 +79,8 @@ def is_DivisorGroup(x):
         sage: is_DivisorGroup('not a divisor')
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_DivisorGroup is deprecated; use 'isinstance(..., DivisorGroup_generic)' instead")
     return isinstance(x, DivisorGroup_generic)
 
 

src/sage/schemes/generic/homset.py

@@ -73,6 +73,8 @@ def is_SchemeHomset(H):
         sage: is_SchemeHomset('a string')
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_SchemeHomset is deprecated; use 'isinstance(..., SchemeHomset_generic)' instead")
     return isinstance(H, SchemeHomset_generic)
 
 

src/sage/schemes/generic/hypersurface.py

@@ -48,8 +48,11 @@ def is_Hypersurface(self):
         sage: is_Hypersurface(H)
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_Hypersurface is deprecated; use 'isinstance(..., (ProjectiveHypersurface, AffineHypersurface))' instead")
     return isinstance(self, (ProjectiveHypersurface, AffineHypersurface))
 
+
 class ProjectiveHypersurface(AlgebraicScheme_subscheme_projective):
     """
     The projective hypersurface defined by the given polynomial.

src/sage/schemes/generic/scheme.py

@@ -49,6 +49,8 @@ def is_Scheme(x):
         sage: is_Scheme(X)
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_Scheme is deprecated; use 'isinstance(..., Scheme)' or categories instead")
     return isinstance(x, Scheme)
 
 
@@ -799,8 +801,11 @@ def is_AffineScheme(x):
         sage: is_AffineScheme(E)
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_AffineScheme is deprecated; use 'isinstance(..., AffineScheme)' instead")
     return isinstance(x, AffineScheme)
 
+
 class AffineScheme(UniqueRepresentation, Scheme):
     """
     Class for general affine schemes.

src/sage/schemes/hyperelliptic_curves/hyperelliptic_generic.py

@@ -53,6 +53,8 @@ def is_HyperellipticCurve(C):
         sage: is_HyperellipticCurve(C)
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_HyperellipticCurve is deprecated; use 'isinstance(..., HyperellipticCurve_generic)' instead")
     return isinstance(C, HyperellipticCurve_generic)
 
 

src/sage/schemes/plane_quartics/quartic_generic.py

@@ -34,8 +34,11 @@ def is_QuarticCurve(C):
         True
 
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_QuarticCurve is deprecated; use 'isinstance(..., QuarticCurve_generic)' instead")
     return isinstance(C, QuarticCurve_generic)
 
+
 class QuarticCurve_generic(projective_curve.ProjectivePlaneCurve):
     # DRK: Note that we should check whether the curve is
 

src/sage/schemes/product_projective/space.py

@@ -77,6 +77,8 @@ def is_ProductProjectiveSpaces(x):
         sage: is_ProductProjectiveSpaces(ProductProjectiveSpaces([1, 2, 3], ZZ, 'x'))
         True
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_ProductProjectiveSpaces is deprecated; use 'isinstance(..., ProductProjectiveSpaces_ring)' instead")
     return isinstance(x, ProductProjectiveSpaces_ring)
 
 

src/sage/schemes/projective/projective_space.py

@@ -146,6 +146,8 @@ def is_ProjectiveSpace(x):
         sage: is_ProjectiveSpace(Spec(ZZ))
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_ProjectiveSpace is deprecated; use 'isinstance(..., ProjectiveSpace_ring)' instead")
     return isinstance(x, ProjectiveSpace_ring)
 
 

src/sage/schemes/toric/chow_group.py

@@ -1220,6 +1220,8 @@ def is_ChowGroup(x) -> bool:
         sage: is_ChowGroup('Victoria')
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_ChowGroup is deprecated; use 'isinstance(..., ChowGroup_class)' instead")
     return isinstance(x, ChowGroup_class)
 
 

src/sage/schemes/toric/fano_variety.py

@@ -179,6 +179,8 @@ def is_CPRFanoToricVariety(x):
         sage: is_CPRFanoToricVariety(ProjectiveSpace(2))
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_CPRFanoToricVariety is deprecated; use 'isinstance(..., CPRFanoToricVariety_field)' instead")
     return isinstance(x, CPRFanoToricVariety_field)
 
 

src/sage/schemes/toric/sheaf/klyachko.py

@@ -71,6 +71,8 @@ def is_KlyachkoBundle(X):
         sage: is_KlyachkoBundle('test')
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_KlyachkoBundle is deprecated; use 'isinstance(..., KlyachkoBundle_class)' instead")
     return isinstance(X, KlyachkoBundle_class)
 
 

src/sage/schemes/toric/variety.py

@@ -361,6 +361,8 @@ def is_ToricVariety(x):
         sage: is_ToricVariety(ProjectiveSpace(2))
         False
     """
+    from sage.misc.superseded import deprecation
+    deprecation(38022, "the function is_ToricVariety is deprecated; use 'isinstance(..., ToricVariety_field)' instead")
     return isinstance(x, ToricVariety_field)