Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sagemath/sage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d1e26af1d7dc4eeb31151d5b8b96305f46d30abc
Choose a base ref
..
head repository: sagemath/sage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f80b805356aa37107237be9e9c943070ebc9e95d
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/sage/plot/animate.py
2 changes: 1 addition & 1 deletion src/sage/plot/animate.py
Original file line number Diff line number Diff line change
@@ -1024,7 +1024,7 @@ def ffmpeg(self, savefile=None, show_path=False, output_format=None,
# afterwards. Hence 'early_options' and 'ffmpeg_options'
# The `-nostdin` is needed to avoid the command to hang, see
# https://stackoverflow.com/questions/16523746/ffmpeg-hangs-when-run-in-background
cmd = 'cd {}; ffmpeg -nostdin -y -f image2 {} -i {} {} {}'.format(
cmd = 'cd {}; {} -nostdin -y -f image2 {} -i {} {} {}'.format(

Check warning on line 1027 in src/sage/plot/animate.py

Codecov / codecov/patch

src/sage/plot/animate.py#L1027

Added line #L1027 was not covered by tests
shlex.quote(pngdir), shlex.quote(FFmpeg().absolute_filename()),
early_options, shlex.quote(pngs), ffmpeg_options, shlex.quote(savefile))
from subprocess import check_call, CalledProcessError, PIPE