Change CompositConstructionFunctor to CompositeConstructionFunctor

[JohnCremona]

I think that CompositConstructionFunctor should be CompositeConstructionFunctor.

Component: categories

Author: John Cremona

Reviewer: David Kirkby

Merged: sage-4.6.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/10318

[JohnCremona]

Attachment: trac_10318-Composit.patch.gz

Applies to 4.6.1.alpha2 + patch from #8807

[sagetrac-drkirkby]

comment:2

I'm a bit puzzled why the need for two patches. Is the combined patch one in which could be used instead of the patch on #8807?

I have no problems giving the small patch a positive reivew. I guess its up to the release manager how best to handle this - whether #8807 is applied first, and then your simple patch, or just your combined patch.

I would have thought the best way to handle this was to just have the simple patch, and make it conditional on #8807 being applied first.

Dave

[sagetrac-drkirkby]

Reviewer: David Kirkby

[sagetrac-drkirkby]

comment:3

Ignore what I said - I see this patch just does many identical spelling corrections - I assumed initially it was just one spelling correction, along with the whole contents of another patch, which made less sence

[JohnCremona]

comment:4

That's right -- I made it conditional on the #8807 patch since that patch has the word in it, and it also makes a lot of changes to the file where most of the occurrences occur.

I'll put a cross-reference at #8807 saying that this ticket has a positive review and can/should be merged right after that one.

[simon-king-jena]

comment:6

depends on #8807

[jdemeyer]

Merged: sage-4.6.2.alpha0