-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divided power algebras #11979
Comments
Attachment: dividedpower.py.gz Attachment: quantumdividedpower.py.gz |
Milestone sage-4.7.3 deleted |
comment:2
here is a patch for the first file. To be continued |
comment:3
Attachment: trac_11979_divided_power.patch.gz Here is a patch including both files |
Commit: |
Branch: u/chapoton/11979 |
Changed author from bruce to Bruce Westbury |
Changed branch from u/chapoton/11979 to public/combinat/divided_power_alg |
comment:7
Minor fixes made. Sorry, not a review. Don't have the time or skills for that (an example should highlight all that one needs to know about the respective categories; I'm not the right person to judge...). Please note the branch change! New commits:
|
comment:9
patchbot:
|
comment:11
I have corrected the doctest, and also cleaned a little bit (up to pep8 standard). |
comment:14
Reviewed the maths. This is a neat piece of example code that would be nice to have in sage, but someone else has to check if this is teaching good coding practices, if it is up to date, and if it isn't missing important parts (I don't see any coercions defined in the code, nor a dedicated |
comment:15
Seems to need rebase. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:18
Actually these imports that caused the conflicts were probably temporary, made for easier testing. The examples in the doctests all begin with an import instruction, so I suspect these algebras were not supposed to be in the global scope. So I've removed them now. Was this a good idea? |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:21
I have gotten rid of all failing doctests, but there is a new one (I think, related to a doctest I added beforehand):
I have no buggering idea what is going wrong here, but I've got a hunch that it might be the same issue as #15475. |
comment:22
Here is a minimal counterexample:
Compare with the following, which does not go wrong:
(It says rc0, but it is rc1 which I have only compiled with ./sage -br instead of make build to avoid building atlas again.) It seems that the category refinement for the bialgebra category goes wrong when first applied over a ring and then over a field, but goes fine the other way roud. (No, this is not fixed by #17096.) |
comment:23
Looks like there are some failed tests and triggered deprecation warnings... |
The two attached files implement divided power algebra as a graded Hopf algebra and the quantum divided power algebra as a graded algebra. This is related to the ticket #11929 on quasisymmetric functions.
I have read
Walking Through the Development Process
but I am not clear on what the process is for me to submit these two files for review and inclusion in sage.
I would also like to add an algebra homomorphism from symmetric functions to the quantum divided power algebra and would appreciate any pointers.
CC: @tscrim @nthiery
Component: combinatorics
Keywords: divided powers
Author: Bruce Westbury
Branch/Commit: public/combinat/divided_power_alg @
103a503
Issue created by migration from https://trac.sagemath.org/ticket/11979
The text was updated successfully, but these errors were encountered: