Skip to content

Numerical noise in chmm.pyx #12283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdemeyer opened this issue Jan 9, 2012 · 4 comments
Closed

Numerical noise in chmm.pyx #12283

jdemeyer opened this issue Jan 9, 2012 · 4 comments

Comments

@jdemeyer
Copy link
Contributor

jdemeyer commented Jan 9, 2012

On cicero:

sage -t -long  -force_lib devel/sage/sage/stats/hmm/chmm.pyx
**********************************************************************
File "/home/buildbot/build/sage/cicero-1/cicero_binary/build/sage-4.8.rc0/devel/sage-main/sage/stats/hmm/chmm.pyx", line 872:
    sage: m.baum_welch(v)
Expected:
    (-162.85437039799817, 49)
Got:
    (-162.8543703979982, 49)
**********************************************************************

I don't know what caused this, but the fix is so easy that I don't want to bother tracking it down.

Component: doctest coverage

Keywords: hidden markov model

Author: Jeroen Demeyer

Reviewer: Marshall Hampton

Merged: sage-4.8.rc0

Issue created by migration from https://trac.sagemath.org/ticket/12283

@jdemeyer
Copy link
Contributor Author

jdemeyer commented Jan 9, 2012

comment:1

Attachment: 12283_chmm_noise.patch.gz

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Jan 9, 2012

comment:2

OK, I checked that this patch works for me; I did not check it on cicero but I think its clear that it fixes this particular problem.

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Jan 9, 2012

Reviewer: Marshall Hampton

@jdemeyer
Copy link
Contributor Author

Merged: sage-4.8.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant