-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In spkgs, run testcc.sh and testcxx.sh without explicit path #12311
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author: John Palmieri |
comment:8
Here are spkgs which make the remaining changes. (Since the necessary changes are mostly trivial, I thought we could deal with them all on this ticket.) Is it worth changing |
This comment has been minimized.
This comment has been minimized.
Attachment: trac_12311-root.patch.gz root repo |
patch for cliquer spkg; for review only |
comment:9
Attachment: trac_12311-cliquer.patch.gz |
This comment has been minimized.
This comment has been minimized.
Attachment: trac_12311-libm4ri.patch.gz patch for libm4ri spkg; for review only |
comment:11
in
should be
|
patch for rubiks spkg; for review only |
comment:12
Attachment: trac_12311-rubiks.patch.gz Oops, sorry, fixed. |
This comment has been minimized.
This comment has been minimized.
Reviewer: Jeroen Demeyer |
comment:13
Looks good to me, thanks! I propose not to apply the SAGE_ROOT patch and leave that to #12631. |
Merged: sage-5.0.beta11 |
#11073 changes the location of
testcc.sh
andtestcxx.sh
tospkg/bin
. The following spkgs refer explicitly to$SAGE_LOCAL/bin/testcc.sh
:sage-env
in a comment inMakefile.patch
)The following spkgs have
testcc.sh
included in the spkg:testcxx.sh
is never used.Changing these spkgs should allow us to stop copying
testcc.sh
andtestcxx.sh
fromspkg/bin
tolocal/bin
in #12631.New spkgs:
Depends on #11073
Depends on #11920
Depends on #12304
Depends on #12694
Component: packages: standard
Author: John Palmieri
Reviewer: Jeroen Demeyer
Merged: sage-5.0.beta11
Issue created by migration from https://trac.sagemath.org/ticket/12311
The text was updated successfully, but these errors were encountered: