Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In spkgs, run testcc.sh and testcxx.sh without explicit path #12311

Closed
jdemeyer opened this issue Jan 15, 2012 · 25 comments
Closed

In spkgs, run testcc.sh and testcxx.sh without explicit path #12311

jdemeyer opened this issue Jan 15, 2012 · 25 comments

Comments

@jdemeyer
Copy link
Contributor

#11073 changes the location of testcc.sh and testcxx.sh to spkg/bin. The following spkgs refer explicitly to $SAGE_LOCAL/bin/testcc.sh:

The following spkgs have testcc.sh included in the spkg:

testcxx.sh is never used.

Changing these spkgs should allow us to stop copying testcc.sh and testcxx.sh from spkg/bin to local/bin in #12631.


New spkgs:

Depends on #11073
Depends on #11920
Depends on #12304
Depends on #12694

Component: packages: standard

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.0.beta11

Issue created by migration from https://trac.sagemath.org/ticket/12311

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor Author

Dependencies: #11073, #11920

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor Author

Changed dependencies from #11073, #11920 to #11073, #11920, #12304

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

comment:8

Here are spkgs which make the remaining changes. (Since the necessary changes are mostly trivial, I thought we could deal with them all on this ticket.) Is it worth changing dir-0.1-install, since that file is likely to disappear anyway? I'll provide a patch for that, too, in case we want to use it for testing.

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

Attachment: trac_12311-root.patch.gz

root repo

@jhpalmieri
Copy link
Member

patch for cliquer spkg; for review only

@jhpalmieri
Copy link
Member

comment:9

Attachment: trac_12311-cliquer.patch.gz

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

Attachment: trac_12311-libm4ri.patch.gz

patch for libm4ri spkg; for review only

@jhpalmieri
Copy link
Member

Changed dependencies from #11073, #11920, #12304 to #11073, #11920, #12304, #12694

@jdemeyer
Copy link
Contributor Author

comment:11

in SPKG.txt,

=== rubiks-20070912.p17 (John Palmieri, 23 March 2012) ===

should be

=== rubiks-20070912.p18 (John Palmieri, 23 March 2012) ===

@jhpalmieri
Copy link
Member

patch for rubiks spkg; for review only

@jhpalmieri
Copy link
Member

comment:12

Attachment: trac_12311-rubiks.patch.gz

Oops, sorry, fixed.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor Author

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link
Contributor Author

comment:13

Looks good to me, thanks!

I propose not to apply the SAGE_ROOT patch and leave that to #12631.

@jhpalmieri
Copy link
Member

comment:14

Replying to @jdemeyer:

Looks good to me, thanks!

I propose not to apply the SAGE_ROOT patch and leave that to #12631.

That's fine with me.

@jdemeyer
Copy link
Contributor Author

Merged: sage-5.0.beta11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants