-
-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded dependencies of the Sage library #12329
Comments
This comment has been minimized.
This comment has been minimized.
Author: Jeroen Demeyer |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
I'm fairly certain the sage library does not need |
comment:5
You are right, I confused with |
comment:6
Coming from sage-on-gentoo, I am not sure at all that GRAPHS needs to be there. We very much build sage without needing mercurial but we do things a bit differently so that one needs caution. I don't think mpmath is needed to build either if it is we have a bug in sage-on-gentoo. |
comment:7
While gdmodule is not needed gd actually is and so is png.
for example from module_list.py. Of course these two are needed for polybori so you are probably covered. readline is also there but other dependencies may include it. I cannot check right now. |
comment:8
Okay, added |
comment:9
Mercurial is needed in the |
comment:10
The new patch works! Needs review. |
comment:11
Looks good to me, I fully agree with that list and cannot see it failing. |
Reviewer: François Bissey |
comment:12
Attachment: 12329_prune_deps.patch.gz I replaced the "sageruntime" target by a "$(SAGERUNTIME)" variable, similar to the "$(BASE)" variable. |
Merged: sage-5.0.beta2 |
According to
spkg/standard/deps
, the sage library depends on:However, only components which are needed at build-time should be listed here.
Apply attachment: 12329_prune_deps.patch to the sage root repository.
With this patch, building just the Sage library using
works fine, also using a parallel build.
Just for information: using "make -j", this is the critical path to build the Sage library (every packge in this list depends on the one just above it):
Component: build
Author: Jeroen Demeyer
Reviewer: François Bissey
Merged: sage-5.0.beta2
Issue created by migration from https://trac.sagemath.org/ticket/12329
The text was updated successfully, but these errors were encountered: