Make "ratpoints" check whether -fnested-functions is supported by the compiler

[jdemeyer]

On Darwin, ratpoints adds -fnested-functions (an Apple extension) to $CFLAGS causing failures when using gcc to compile.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ratpoints-2.1.3.p2.spkg

Depends on #12367

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: R. Andrew Ohana

Merged: sage-5.0.beta5

Issue created by migration from https://trac.sagemath.org/ticket/12368

[ohanar]

comment:2

shouldn't you append testflags.sh -fnested-functions to CCFLAGS?

[williamstein]

comment:3

Replying to @ohanar:

shouldn't you append testflags.sh -fnested-functions to CCFLAGS?

I'm not sure. However, if he did then he would be changing how the spkg-install scripts works from before. It did not used to append to CCFLAGS -- it always wrote it from scratch. So I think appending or not is orthogonal to refereeing this patch; it could be another ticket.

My question is: what the heck is testcflags.sh? It doesn't exist on my OS X 10.7 install, or in Sage-5.0x as far as I can tell, or in this spkg... So I can't referee this package.

[jdemeyer]

comment:4

Replying to @williamstein:

My question is: what the heck is testcflags.sh?

See #12367 (a dependency of this ticket).

It doesn't exist on my OS X 10.7 install

Did you look in $SAGE_ROOT/spkg/bin?

[jdemeyer]

Diff for the ratpoints spkg, for review only

[jdemeyer]

comment:5

Attachment: ratpoints-2.1.3.p1-p2.diff.gz

Replying to @williamstein:

I'm not sure. However, if he did then he would be changing how the spkg-install scripts works from before. It did not used to append to CCFLAGS -- it always wrote it from scratch.

I agree with R. Andrew, so I'm copying $CFLAGS to $CCFLAGS in spkg-install. Needs review.

[ohanar]

Reviewer: R. Andrew Ohana

[ohanar]

comment:6

Replying to @williamstein:

So I think appending or not is orthogonal to refereeing this patch; it could be another ticket.

Note that I did not mark it as needs work, I definitely agree that it is not necessary for refereeing this ticket. I would have given it a positive review regardless (since it did what it was supposed to do), but since it is a trivial change that improves the build process, and since he was already touching the CCFLAGS variable, I figured it couldn't hurt to actually have the global CFLAGS respected.

[williamstein]

comment:7

Replying to @jdemeyer:

Replying to @williamstein:

My question is: what the heck is testcflags.sh?

See #12367 (a dependency of this ticket).

It doesn't exist on my OS X 10.7 install

Did you look in $SAGE_ROOT/spkg/bin?

Yes, but I guess sage-5.0.beta2 is too old. I'll let somebody else referee this:

deep:~ wstein$ cd s/spkg/bin/
deep:bin wstein$ ls
json_bundle.py	sage-env	testcc.sh	text-collapse
sage		sage-spkg	testcxx.sh	text-expand
deep:bin wstein$ sage -version
Sage Version 5.0.beta2, Release Date: 2012-02-03

[jdemeyer]

Merged: sage-5.0.beta5