Improved uniqueness for combinatorial free modules

[hivert]

Depending on how they was created, some free modules were different. They are now unique thanks to the classcall mechanism.

I moreover removed a unused code constructing the one of the base ring in __init__.

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: CombiantorialFreeModule, UniqueRepresentation, Cernay2012

Author: Florent Hivert, Nicolas M. Thiéry

Reviewer: Nicolas M. Thiéry, Florent Hivert

Merged: sage-5.0.beta4

Issue created by migration from https://trac.sagemath.org/ticket/12464

[nthiery]

Changed keywords from CombiantorialFreeModule, UniqueRepresentation to CombiantorialFreeModule, UniqueRepresentation, Cernay2012

[nthiery]

comment:2

Cross reviewed in Cernay. Positive review!

[nthiery]

Reviewer: Nicolas M. Thiéry, Florent Hivert

[jdemeyer]

comment:3

Could this cause

sage -t  -force_lib devel/sage/doc/en/thematic_tutorials/lie/iwahori_hecke_algebra.rst
**********************************************************************
File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/devel/sage-main/doc/en/thematic_tutorials/lie/iwahori_hecke_algebra.rst", line 54:
    sage: H = IwahoriHeckeAlgebraT("B3",q); H
Exception raised:
    Traceback (most recent call last):
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[3]>", line 1, in <module>
        H = IwahoriHeckeAlgebraT("B3",q); H###line 54:
    sage: H = IwahoriHeckeAlgebraT("B3",q); H
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-packages/sage/misc/classcall_metaclass.py", line 274, in __call__
        return cls.__classcall_private__(cls, *args, **options)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-packages/sage/algebras/iwahori_hecke_algebra.py", line 174, in __classcall_private__
        return super(IwahoriHeckeAlgebraT, cls).__classcall_private__(cls, W, q1=q1, q2=q2, base_ring=base_ring, prefix=prefix)
    TypeError: __classcall_private__() got multiple values for keyword argument 'base_ring'
**********************************************************************

[nthiery]

comment:4

Oops, sorry; I apparently did not upload the latest version in the queue. There it is!

[nthiery]

Changed author from Florent Hivert, Nicolas Thiéry to Florent Hivert, Nicolas M. Thiéry

[nthiery]

comment:5

Attachment: trac_12464-free_module_classcall-fh.patch.gz

[jdemeyer]

Merged: sage-5.0.beta4