Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make micro_release doesn't work #13004

Closed
williamstein opened this issue May 25, 2012 · 11 comments
Closed

make micro_release doesn't work #13004

williamstein opened this issue May 25, 2012 · 11 comments

Comments

@williamstein
Copy link
Contributor

wstein@sage:/scratch/wstein/may/sage-5.0.rc1$ make micro_release
bash -c ". spkg/bin/sage-env && local/bin/sage-micro_release"
Stripping .so files in local/lib
strip "/scratch/wstein/may/sage-5.0.rc1/local/lib/libzn_poly.so"
...
strip "/scratch/wstein/may/sage-5.0.rc1/local/lib/libpython2.7.so"
bash: line 1: 31544 Segmentation fault      local/bin/sage-micro_release
make: *** [micro_release] Error 139
wstein@sage:/scratch/wstein/may/sage-5.0.rc1$ 

Component: build

Author: Volker Braun

Reviewer: Marc Mezzarobba

Merged: sage-5.10.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13004

@williamstein
Copy link
Contributor Author

comment:1

Oops -- stripping python from a python script!?

@vbraun
Copy link
Member

vbraun commented Jul 3, 2012

Initial patch

@vbraun
Copy link
Member

vbraun commented Jul 3, 2012

comment:2

Attachment: trac_x_fix_micro_release.patch.gz

The attached patch splits sage-micro_release into a shell script that does the stripping
and a python script that does all the rest.

@mezzarobba
Copy link
Member

comment:3

Why isn't this ticket flagged need_review?

@mezzarobba
Copy link
Member

Author: Volker Braun

@mezzarobba
Copy link
Member

comment:4

Anyway, the patch looks reasonable and works for me, so I took the liberty to give it positive_review. I hope this is acceptable.

(Apply to local/bin.)

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@jdemeyer
Copy link
Contributor

jdemeyer commented May 7, 2013

comment:5

Would it not be a good idea to limit the stripping to files which are executable?

find "$SAGE_LOCAL/bin" "$SAGE_LOCAL/lib" -type f -executable -exec strip '{}' ';'

@vbraun
Copy link
Member

vbraun commented May 7, 2013

comment:6

You can also strip static libraries (.a) and those should not be executable.

@jpflori
Copy link
Contributor

jpflori commented May 9, 2013

comment:7

I guess #11743 becomes a duplicate.

@jdemeyer
Copy link
Contributor

Merged: sage-5.10.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants