Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor squarefree_decomposition to allow different rings to chose different implementations #13008

Closed
saraedum opened this issue May 25, 2012 · 9 comments
Closed

refactor squarefree_decomposition to allow different rings to chose different implementations #13008

saraedum opened this issue May 25, 2012 · 9 comments
Assignees
@aghitza
Labels
c: algebra p: minor / 4 t: enhancement
Milestone
sage-6.3

Comments

@saraedum
Copy link
Member

Refactor squarefree_decomposition() of univariate polynomials to call _squarefree_decomposition_univariate() of the base ring. This makes it easier to have different algorithms in different rings.

This will make it easier to implement square-free decomposition over perfect fields and separably generated extensions of perfect fields.

Also, the implemented algorithms only work for some base fields. The checks are now more specific.

Depends on #12404
Depends on #13048

Component: algebra

Keywords: polynomial, squarefree, sd59

Author: Julian Rueth

Branch/Commit: 29264c6

Reviewer: Martin Albrecht

Issue created by migration from https://trac.sagemath.org/ticket/13008
@saraedum saraedum added this to the sage-5.11 milestone May 25, 2012
@saraedum
Copy link
Member Author

Changed dependencies from #12404 to #12404, #13048

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@saraedum
Copy link
Member Author

Branch: u/saraedum/ticket/13008

@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member Author

Author: Julian Rueth

@saraedum
Copy link
Member Author

Changed keywords from polynomial, squarefree to polynomial, squarefree, sd59

@malb
Copy link
Member

malb commented Jun 27, 2014

comment:7

Looks good & we discussed the design decision.

New commits:

29264c6Refactor squarefree_decomposition of polynomials

@malb
Copy link
Member

malb commented Jun 27, 2014

Commit: 29264c6

@malb
Copy link
Member

malb commented Jun 27, 2014

Reviewer: Martin Albrecht

@vbraun
Copy link
Member

vbraun commented Jun 28, 2014

Changed branch from u/saraedum/ticket/13008 to 29264c6

@vbraun vbraun closed this as completed in 5112ce7 Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.3
Development

No branches or pull requests
5 participants
@saraedum @aghitza @vbraun @malb @jdemeyer