-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating PolyBoRi to release 0.8.2 #13124
Comments
comment:1
The spkg is in place now. |
Author: AlexanderDreyer |
comment:2
Only issue: I think it's our policy not to have .p0 for fresh packages, but just the name. Can you drop the .p0? |
Reviewer: Martin Albrecht |
Changed author from AlexanderDreyer to Alexander Dreyer |
comment:3
Replying to @malb:
No problem, the updated spkg (renamed and changed tag line in |
This comment has been minimized.
This comment has been minimized.
comment:5
All done then. :) |
comment:7
I just updated the spkg to include the following patch in the upstream sources: |
comment:8
@malb Staying positive reviewed? |
comment:9
Please don't name the spkg version "0.8.2" if polybori-0.8.2 hasn't actually been released! If the upstream version is called "0.8.2rc1", then so should the Sage version be (including in |
Work Issues: version number |
comment:11
We are currently co-developing. PolyBoRi 0.8.2 will be whatever the result of this ticket is. |
comment:12
That makes sense, you you should really make sure that the upstream polybori-0.8.2 is identical to the Sage polybori-0.8.2. Believe me, I have seen this kind of problems in the past with other packages where the upstream version was close to, but not quite equal to the Sage version. |
comment:13
Replying to @jdemeyer:
Because packages like PolyBoRi (and e.g., M4RI) wait for Sage's tests to pass before releasing, this strategy would create unnecessary bureaucracy. We'd do a rcX, Sage includes the package, we another package which is the final. |
comment:14
Replying to @alexanderdreyer:
Yep. |
comment:15
Positive review then. |
Changed work issues from version number to none |
comment:16
Understanding that spkgs could be messed up, I document the source matching here:
|
comment:17
I just noticed that polybori was the culprit for the |
comment:18
Fails to build on
|
comment:19
I fixed that issue and added an updated spkg at the same place. |
comment:20
The download link gives a 404 Not Found error. |
Work Issues: HTTP 404 |
Changed work issues from HTTP 404 to none |
comment:21
Sorry, I'd accidentally put it to the wrong dir. Now it's at the correct url. |
comment:22
Compiles fine on |
Merged: sage-5.2.beta1 |
comment:24
Just for documentation: the sources of
|
PolyBoRi's next minor release will be out soon.
There were no changes of the interface between PolyBoRi 0.8.2 and 0.8.1, so we just have to update the sources from here:
https://sourceforge.net/projects/polybori/files/polybori/0.8.2rc
PolyBoRi 0.8.2 is a bugfix release incorporating all previous patches from Sage.
Current spkg
Upstream: None of the above - read trac for reasoning.
CC: @sagetrac-PolyBoRi @malb @burcin
Component: packages: standard
Author: Alexander Dreyer
Reviewer: Martin Albrecht
Merged: sage-5.2.beta1
Issue created by migration from https://trac.sagemath.org/ticket/13124
The text was updated successfully, but these errors were encountered: