Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discriminant of Hecke algebra is broken #13212

Closed
aghitza opened this issue Jul 8, 2012 · 7 comments
Closed

discriminant of Hecke algebra is broken #13212

aghitza opened this issue Jul 8, 2012 · 7 comments

Comments

@aghitza
Copy link
Contributor

aghitza commented Jul 8, 2012


----------------------------------------------------------------------
| Sage Version 5.0, Release Date: 2012-05-14                         |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: H = CuspForms(1, 24).hecke_algebra()
sage: H.discriminant()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/ghitza/<ipython console> in <module>()

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/modular/hecke/algebra.pyc in discriminant(self)
    523         except AttributeError:
    524             pass
--> 525         basis = self.basis()
    526         d = len(basis)
    527         if d <= 1:

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/modular/hecke/algebra.pyc in basis(self)
    472             pass
    473         level = self.level()
--> 474         bound = self.__M.hecke_bound()
    475         dim = self.__M.rank()
    476         if dim == 0:

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/structure/parent.so in sage.structure.parent.Parent.__getattr__ (sage/structure/parent.c:6732)()

/opt/sage-5.0/local/lib/python2.7/site-packages/sage/structure/parent.so in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:3248)()

AttributeError: 'CuspidalSubmodule_level1_Q_with_category' object has no attribute 'hecke_bound'

Component: modular forms

Keywords: discriminant hecke beginner sd51

Author: Alejandro Argaez

Reviewer: Alex Ghitza

Merged: sage-5.12.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13212

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 22, 2013

Changed keywords from discriminant hecke to discriminant hecke beginner sd51

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 22, 2013

comment:1

This can be corrected in one line by replacing the call to hecke_bound with sturm_bound.

@loefflerd loefflerd mannequin added the good first issue label Jul 22, 2013
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 23, 2013

comment:2

Correction: what I posted above is wrong -- this would be dangerous and introduce some odd bugs! Better would be to move the definition of hecke_bound in sage/modular/modsym/subspace.py to sage/modular/hecke/submodule.py. That is, I think, the minimally invasive way to make Hecke algebras of cuspidal modform spaces work properly.

@sagetrac-ArgaezG
Copy link
Mannequin

sagetrac-ArgaezG mannequin commented Jul 23, 2013

Attachment: trac_13212.patch.gz

Sage 5.10

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 24, 2013

Author: Alejandro Argaez

@loefflerd loefflerd mannequin added the s: needs review label Jul 24, 2013
@aghitza
Copy link
Contributor Author

aghitza commented Jul 24, 2013

Reviewer: Alex Ghitza

@jdemeyer
Copy link
Contributor

Merged: sage-5.12.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants