Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CDF._factor_univariate_polynomial() #13276

Closed
saraedum opened this issue Jul 19, 2012 · 8 comments
Closed

Add CDF._factor_univariate_polynomial() #13276

saraedum opened this issue Jul 19, 2012 · 8 comments
Assignees
@aghitza
Labels
c: basic arithmetic good first issue p: minor / 4 t: bug
Milestone
sage-6.2

Comments

@saraedum
Copy link
Member

As a part of #11731, transfer the code which does the factorization over CDF and RDF from sage.rings.polynomial.polynomial_element.Polynomial.factor() to CDF._factor_univariate_polynomial() and RDF._factor_univariate_polynomial() respectively.

This will also fix the following bug:

sage: R.<x> = CDF[]
sage: (x^2).factor()
AssertionError

Depends on #13275

Component: basic arithmetic

Author: Julian Rueth

Branch/Commit: ce12073

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/13276
@saraedum saraedum added this to the sage-5.11 milestone Jul 19, 2012
@saraedum
Copy link
Member Author

comment:1

Attachment: trac_13276.patch.gz

@saraedum
Copy link
Member Author

Author: Julian Rueth

@pjbruin
Copy link
Contributor

pjbruin commented Jun 15, 2013

Reviewer: Peter Bruin

@sagetrac-asalerno
Copy link
Mannequin

sagetrac-asalerno mannequin commented Jul 11, 2013

comment:3

This patch depends on #13274, which no longer applies to Sage 5.10.rc1.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

Commit: ce12073

@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

comment:6

Converted patch to a Git branch, only trivial merge conflicts and whitespace edits. Looks good, all test pass.

@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

Branch: u/pbruin/13276-CDF_factor_univariate_polynomial

@vbraun
Copy link
Member

vbraun commented Feb 26, 2014

Changed branch from u/pbruin/13276-CDF_factor_univariate_polynomial to ce12073

@vbraun vbraun closed this as completed in d1e77b2 Feb 26, 2014
@haikona haikona mannequin mentioned this issue Dec 29, 2022
Open
@saraedum saraedum mentioned this issue Jul 1, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: basic arithmetic good first issue p: minor / 4 t: bug
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
5 participants
@saraedum @aghitza @vbraun @jdemeyer @pjbruin