Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegerListsLex speedup #13840

Closed
tscrim opened this issue Dec 18, 2012 · 9 comments
Closed

IntegerListsLex speedup #13840

tscrim opened this issue Dec 18, 2012 · 9 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Dec 18, 2012

This patch speeds up IntegerListsLex by removing calls to sage's infinity and instead uses float('+inf') and float('-inf').

Before the patch:

sage: time p = Partitions(150, max_slope=-1, length=15).list()        
Time: CPU 14.04 s, Wall: 14.64 s

After:

sage: time p = Partitions(150, max_slope=-1, length=15).list()
Time: CPU 3.97 s, Wall: 4.14 s

Depends on #14045

CC: @sagetrac-sage-combinat @nthiery

Component: combinatorics

Keywords: optimization, integerlistlex

Author: Travis Scrimshaw

Reviewer: Mike Hansen

Merged: sage-5.7.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13840

@tscrim
Copy link
Collaborator Author

tscrim commented Dec 23, 2012

comment:2

Fixed the doctest in integer_vector.py.

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 31, 2013

Dependencies: #14045

@mwhansen
Copy link
Contributor

mwhansen commented Feb 3, 2013

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Feb 3, 2013

comment:5

Looks good to me.

@jdemeyer
Copy link
Contributor

jdemeyer commented Feb 4, 2013

comment:6

How was this patch file created? It is missing a "User" field, you should create a $HOME/.hgrc file as explained in http://sagemath.org/doc/developer/producing_patches.html and export the patch using hg export tip.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2013

Attachment: trac_13840-integer_list_speedup-ts.patch.gz

Fixed doctest

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 4, 2013

comment:7

Fixed.

@jdemeyer
Copy link
Contributor

jdemeyer commented Feb 5, 2013

Merged: sage-5.7.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants