Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace in coercion_and_categories.rst #14182

Closed
jdemeyer opened this issue Feb 25, 2013 · 8 comments
Closed

Fix whitespace in coercion_and_categories.rst #14182

jdemeyer opened this issue Feb 25, 2013 · 8 comments
Assignees
@sagetrac-mvngu
Labels
c: documentation p: blocker / 1 t: bug
Milestone
sage-5.8

Comments

@jdemeyer
Copy link
Contributor

devel/sage/doc/en/thematic_tutorials/coercion_and_categories.rst mixes TABs and spaces for indentation, which is very bad style and might also lead to doctesting trouble.

Depends on #11490

CC: @simon-king-jena

Component: documentation

Author: Jeroen Demeyer

Reviewer: Simon King

Merged: sage-5.8.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14182
@jdemeyer jdemeyer added this to the sage-5.8 milestone Feb 25, 2013
@simon-king-jena
Copy link
Member

comment:1

How to replace tabs by four blank spaces (in linux or vim)? Perhaps you can answer faster than I can look up in google...

@jdemeyer
Copy link
Contributor Author

Attachment: 14182_whitespace.patch.gz

@jdemeyer
Copy link
Contributor Author

Author: Jeroen Demeyer

@simon-king-jena
Copy link
Member

comment:3

OK, you were faster. I found sed 's/\\t/ /g' oldcode.py >newcode.py in google...

@simon-king-jena
Copy link
Member

comment:4

Good. After applying the patch, I could not find any tab space in the code. Since the patch does not change the actual text, since the documentation built w/o trouble, and since the result looks fine in the browser, I give it a positive review.

@simon-king-jena
Copy link
Member

Reviewer: Simon King

@roed314
Copy link
Contributor

roed314 commented Feb 27, 2013

Dependencies: #11490

@jdemeyer
Copy link
Contributor Author

Merged: sage-5.8.beta2

@robertwb robertwb mentioned this issue Jun 15, 2013
Closed
@simon-king-jena simon-king-jena mentioned this issue Mar 7, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-mvngu sagetrac-mvngu

Labels
c: documentation p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-5.8
Development

No branches or pull requests
3 participants
@roed314 @jdemeyer @simon-king-jena