Remove redundant classcall_private from partitions

[simon-king-jena]

This is a follow-up to #13605. I think that several __classcall_private__ methods in sage.combinat.partition are not needed.

There are some __classcall_private__ methods that do an extensive preprocessing, or that deal with optional arguments. I work on making the latter automatic. But currently, thee __classcall_private__ applications make sense.

However, I doubt that a __classcall_private__ method makes sense that simply puts a Integer(k) around an argument k that is supposed to be an integer (python int or whatever). Since caching is by equality and since k as int, Integer, NN, QQ etc. evaluates equal, caching is not an issue here.

Depends on #13605
Depends on #11410

CC: @sagetrac-sage-combinat @tscrim

Component: combinatorics

Keywords: partition classcall

Author: Simon King

Reviewer: Travis Scrimshaw

Merged: sage-5.8.beta4

Issue created by migration from https://trac.sagemath.org/ticket/14225

[simon-king-jena]

comment:2

Oops, I forgot to document the new cached function. Patch updated.

[simon-king-jena]

comment:3

I think it is better to keep separate topics on separate tickets. Hence, I only remove __classcall_private__ here, but do not cache stuff.

[tscrim]

Changed dependencies from #13605 to #13605 #11410

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:4

Could you rebase this over #11410 (which is essentially done)? Other than that, it looks good.

Thanks Simon,

Travis

[simon-king-jena]

comment:5

I am just thinking: Shouldn't Partitions() (called without arguments) be cached? This is only a single value, and it occurs frequently in the code.

[simon-king-jena]

Attachment: trac_14225-partition_classcall_private.patch.gz

[simon-king-jena]

comment:6

Done.

[tscrim]

comment:7

Looks good to me. Thank you,

Travis

[simon-king-jena]

comment:9

"Pending" because of #11410?

[jdemeyer]

comment:10

Yes, but in any case it would be sage-5.9, not sage-5.8.

[jdemeyer]

Changed dependencies from #13605 #11410 to #13605, #11410

[jdemeyer]

comment:11

Changing my mind because of #14228.

[jdemeyer]

Merged: sage-5.8.beta4