-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __len__ and cardinality to cartesian_product_iterator and CartesianProduct #14285
Comments
Author: David Roe |
comment:4
Minor issue: The description of the patch has no trac ticket number. |
comment:5
I'm happy with it if the patchbot is. |
Reviewer: Julian Rueth |
This comment has been minimized.
This comment has been minimized.
comment:7
I'm also happy with it once the patchbot approves. |
comment:8
Updated to fix doctest failures... |
comment:10
On 32-bit systems:
|
Attachment: 14285.patch.gz |
Attachment: trac_14285_review.patch.gz review patch |
comment:11
Fixed. |
Merged: sage-5.9.beta1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If cartesian_product_iterator has a
__len__
method we can use it inrandom.sample
.We also fix a bug that yields an infinite loop:
Apply:
CC: @hivert
Component: combinatorics
Author: David Roe
Reviewer: Julian Rueth
Merged: sage-5.9.beta1
Issue created by migration from https://trac.sagemath.org/ticket/14285
The text was updated successfully, but these errors were encountered: