Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest debugger doesn't work on OS X #14289

Closed
roed314 opened this issue Mar 17, 2013 · 11 comments
Closed

Doctest debugger doesn't work on OS X #14289

roed314 opened this issue Mar 17, 2013 · 11 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 17, 2013

sage -t --debug, a new doctesting feature introduced by #12415, doesn't work for me on OS X 10.6.8 (it starts the tests but then just hangs). Strangely, the tests in sage.doctest.forker.SageDocTestRunner.report_unexpected_exception seem to succeed.

Can anyone else duplicate this problem on another platform?

Depends on #12415

Component: doctest framework

Author: Jeroen Demeyer

Reviewer: David Roe

Merged: sage-5.9.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14289

@roed314

This comment has been minimized.

@jdemeyer
Copy link
Contributor

comment:2

Did you check that it is really attachment: 12415_review.patch:ticket:12415 which breaks this and not one of the subsequent patches in #12415?

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor

comment:3

Adding back

import readline

in init_sage() seems to solve the problem.

@jdemeyer jdemeyer changed the title Doctest debugger doesn't work Doctest debugger doesn't work on OS X Mar 17, 2013
@jdemeyer
Copy link
Contributor

Author: Jeroen Demeyer

@jdemeyer
Copy link
Contributor

comment:4

Attachment: 14289_doctest_readline.patch.gz

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

comment:5

Thanks for figuring out what was causing this. The only change I would suggest is using

:trac:`14249`

rather than

https://github.com/sagemath/sage-prod/issues/14289

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

Reviewer: David Roe

@jdemeyer
Copy link
Contributor

comment:7

I think that

:trac:`14249`

should be used in and only in docstrings.

So I propose to leave the comment (unless you prefer Trac #14289 to the full URL).

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

comment:8

Yes, you're right. Then it looks fine to me.

@jdemeyer
Copy link
Contributor

Merged: sage-5.9.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants