Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular crystals category #14454

Closed
tscrim opened this issue Apr 15, 2013 · 22 comments
Closed

Regular crystals category #14454

tscrim opened this issue Apr 15, 2013 · 22 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Apr 15, 2013

Currently the crystals category assumes that all crystals are regular. With #14192 and #14413, there are non-regular crystals going into Sage. This will add a new subcategory of crystals for regular crystals.


Apply: attachment: trac_14454-regular_crystals-ts.patch

Depends on #14252
Depends on #14287

CC: @sagetrac-sage-combinat @bsalisbury1 @anneschilling @nthiery

Component: categories

Keywords: normal crystals

Author: Travis Scrimshaw, Anne Schilling

Reviewer: Anne Schilling, Travis Scrimshaw

Merged: sage-5.10.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14454

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 15, 2013

Changed dependencies from #14413 to none

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 15, 2013

comment:2

Changing dependencies to make #14402 a dependency of this ticket.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 15, 2013

Dependencies: #14252

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 15, 2013

comment:5

After some discussion with Ben, we decided to call these regular crystals (this agrees with the crystals tutorial).

For patchbot:

Apply: trac_14454-regular_crystals-ts.patch

@tscrim tscrim changed the title Normal crystals category Regular crystals category Apr 15, 2013
@anneschilling
Copy link
Contributor

Reviewer: Anen Schilling, Travis Scrimshaw

@anneschilling
Copy link
Contributor

Changed author from Travis Scrimshaw to Travis Scrimshaw, Anne Schilling

@anneschilling

This comment has been minimized.

@anneschilling
Copy link
Contributor

comment:7

I posted a review patch which moves some material to the appropriate category. There is still one issue: there are tests for the Stembridge rules in the finite crystal category. But really they should be in a finite/regular category. Should we create a separate category for finite regular crystals?

Anne

@bsalisbury1
Copy link
Contributor

comment:8

I believe the Stembridge axioms are valid for any crystal with a simply-laced Cartan matrix, with no assumption that the crystal is finite. Can the Stembridge axioms be moved to the regular crystals category with an added condition that if the cardinality of the crystal is infinite (or unknown), then only test to finite depth?

@anneschilling
Copy link
Contributor

comment:9

I tried this, but then the tests in generalized_young_walls.py did not pass any longer.

Anne

@anneschilling
Copy link
Contributor

comment:10

I should say for the highest weight crystals in that file.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 26, 2013

comment:11

New version of the patch with the review patch folded in and a couple of other tweaks.

@tscrim

This comment has been minimized.

@jdemeyer
Copy link
Contributor

Changed dependencies from #14252 to #14252, #14287

@jdemeyer
Copy link
Contributor

comment:13

This needs to be rebased to #14287.

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 29, 2013

Attachment: trac_14454-regular_crystals-ts.patch.gz

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 29, 2013

comment:14

Fixed doctest from changes in #14287.

@jdemeyer
Copy link
Contributor

jdemeyer commented May 7, 2013

Changed reviewer from Anen Schilling, Travis Scrimshaw to Anne Schilling, Travis Scrimshaw

@jdemeyer
Copy link
Contributor

jdemeyer commented May 7, 2013

Merged: sage-5.10.beta2

@jdemeyer
Copy link
Contributor

comment:17

The following doctest really takes too long:

**********************************************************************
File "devel/sage/sage/combinat/crystals/generalized_young_walls.py", line 850, in sage.combinat.crystals.generalized_young_walls.HighestWeightCrystalOfGYW.__init__
Failed example:
    TestSuite(YLa).run() # long time
Test ran for 203.43 s
**********************************************************************

It is by far the longest doctest in all of Sage. Can this test be made faster? Or removed in the worst case?

@tscrim
Copy link
Collaborator Author

tscrim commented May 19, 2013

comment:18

Hey Jeroen,

I'm working on it right now. I'll let you know what I find.

Best,

Travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants