-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement path realization for affine crystals #14573
Comments
comment:2
Hi Travis, The name of the class is not good. I would rather name such a class KyotoPathModel. Also, there are several things stated wrong in the documentation. In addition, several methods do not explain their input. And why only input one B crystal? This model works in much greater generality. It might be good if you could talk to people first to see what the needs are and what the best way to implement them are. Best wishes, Anne |
comment:4
Hey Anne, New version of the patch which does not depend on #14516 and addresses what we discussed. Best, Travis |
comment:5
New version with changes from Ben. |
Changed keywords from affine crystals to affine crystals, days49 |
Reviewer: Ben Salisbury |
Changed reviewer from Ben Salisbury to Ben Salisbury, Anne Schilling |
comment:8
Hi Travis, I have some further comments:
Thank you, Anne |
comment:9
All are done. I added an example showing it works with multiple crystals, and affine grading is inherited from the |
comment:10
Hi Travis and Ben, I just discussed with Travis and he needs to change three more things:
Ben, Travis will make these changes tomorrow and once he has done it, you can set it to positive review. Anne |
comment:11
Attachment: trac_14573-path_realizations-ts.patch.gz Fixed and ready for a final review. |
Merged: sage-5.12.beta1 |
Depends on #14402
CC: @sagetrac-sage-combinat @bsalisbury1 @anneschilling
Component: combinatorics
Keywords: affine crystals, days49
Author: Travis Scrimshaw
Reviewer: Ben Salisbury, Anne Schilling
Merged: sage-5.12.beta1
Issue created by migration from https://trac.sagemath.org/ticket/14573
The text was updated successfully, but these errors were encountered: