Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "cythonizing out-of-tree" until sage-sync-build and sage-clone can deal with that #14721

Closed
nexttime mannequin opened this issue Jun 11, 2013 · 9 comments
Closed

Comments

@nexttime
Copy link
Mannequin

nexttime mannequin commented Jun 11, 2013

See #13245 and the sage-devel thread on useless rebuilding of the Sage library ...

The patch effectively reverts the change to setup.py made by attachment: ticket:14570:trac14570.patch (btw. the only functional change of that patch).


Apply: attachment: trac_14721-postpone_cythonizing_out_of_tree.sagelib.patch

Component: build

Keywords: useless rebuild library build_dir

Author: Leif Leonhardy

Reviewer: Travis Scrimshaw

Merged: sage-5.10.rc2

Issue created by migration from https://trac.sagemath.org/ticket/14721

@nexttime nexttime mannequin added this to the sage-5.10 milestone Jun 11, 2013
@nexttime nexttime mannequin added c: build labels Jun 11, 2013
@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Jun 11, 2013

Changed keywords from none to useless rebuild library build_dir

@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Jun 11, 2013

Attachment: trac_14721-postpone_cythonizing_out_of_tree.sagelib.patch.gz

Apply to the Sage library. Based on Sage 5.10.rc1.

@nexttime

This comment has been minimized.

@nexttime nexttime mannequin added the s: needs review label Jun 11, 2013
@tscrim
Copy link
Collaborator

tscrim commented Jun 11, 2013

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 11, 2013

comment:3

This worked for me (with possibly #13245).

Edit wrt comment:5 - Yes I did

@tscrim
Copy link
Collaborator

tscrim commented Jun 11, 2013

comment:4

Thanks for looking into this Leif.

@nexttime
Copy link
Mannequin Author

nexttime mannequin commented Jun 11, 2013

comment:5

Replying to @tscrim:

This worked for me (with possibly #13425).

I guess you meant #13245.

@nexttime

This comment has been minimized.

@jdemeyer
Copy link
Contributor

Merged: sage-5.10.rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants