Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariate power series are missing integral and division method #14814

Closed
hivert opened this issue Jun 25, 2013 · 17 comments
Closed

Multivariate power series are missing integral and division method #14814

hivert opened this issue Jun 25, 2013 · 17 comments

Comments

@hivert
Copy link
Contributor

hivert commented Jun 25, 2013

sage: R.<x>=PowerSeriesRing(QQ, 'x')
sage: (x+x^2).integral()
1/2*x^2 + 1/3*x^3
sage: R.<x,y>=PowerSeriesRing(QQ, 'x y')
sage: (x+x^2).integral(x)
...
AttributeError: 'MPowerSeries' object has no attribute 'integral'

I also implement division by a non unit series (thanks Nicolas for preliminary code) and fixes the latex method which was buggy

Apply:

Component: algebra

Keywords: integral multivariate power series

Author: Florent Hivert, Nicolas M. Thiéry

Branch/Commit: u/vbraun/series_integral_div @ 02333e3

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/14814

@hivert hivert added this to the sage-6.1 milestone Jun 25, 2013
@hivert

This comment has been minimized.

@hivert
Copy link
Contributor Author

hivert commented Jun 28, 2013

Author: Florent Hivert, Nicolas Thiéry

@hivert

This comment has been minimized.

@hivert hivert changed the title Mulitvariate power series are missing an integral method Mulitvariate power series are missing integral and division method Jun 28, 2013
@fchapoton
Copy link
Contributor

comment:3

Attachment: trac_14814-power_series_inverse_latex-fix-fh.patch.gz

this may interfere with #14334

@fchapoton fchapoton changed the title Mulitvariate power series are missing integral and division method Multivariate power series are missing integral and division method Aug 22, 2013
@fchapoton
Copy link
Contributor

comment:5

It seems that there is no conflict with #14334

2 remarks:

  • there is a typo in quo_rem: increassing

  • please use the new syntax ValueError('please')

@fchapoton
Copy link
Contributor

comment:6

I have made a review patch. If you are happy with the few small changes I have made, you can set a positive review.

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:7

Attachment: trac_14814_review.patch.gz

Ping ! Florent ? anybody else ?

@fchapoton
Copy link
Contributor

comment:8

Ping again ! Nobody available to have a look at this ticket ?

@darijgr
Copy link
Contributor

darijgr commented Nov 13, 2013

another review patch, atop of the previous one

@darijgr
Copy link
Contributor

darijgr commented Nov 13, 2013

comment:9

Attachment: trac_14814-review-2-dg.patch.gz

New review patch allows the denominator to lie in a different parent (as long as it coerces into that of the numerator), deals with an endless-loop bug, and adds doc and comments. If you are fine with it, Frederic and Florent, this is positive_review!

for the patchbot

apply trac_14814-power_series_inverse_latex-fix-fh.patch​ trac_14814_review.patch​ trac_14814-review-2-dg.patch

@darijgr

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Dec 23, 2013

Branch: u/vbraun/series_integral_div

@vbraun
Copy link
Member

vbraun commented Dec 23, 2013

New commits:

02333e3trac #14814: review patch
09c2670trac #14814 review patch (minor details)
aeea9a1Implement integration and division or power series.

@vbraun
Copy link
Member

vbraun commented Dec 23, 2013

Commit: 02333e3

@darijgr
Copy link
Contributor

darijgr commented Dec 23, 2013

comment:12

Thanks for the final review, Volker!

@jdemeyer
Copy link
Contributor

jdemeyer commented Feb 3, 2014

Changed author from Florent Hivert, Nicolas Thiéry to Florent Hivert, Nicolas M. Thiéry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants