-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multivariate power series are missing integral and division method #14814
Comments
This comment has been minimized.
This comment has been minimized.
Author: Florent Hivert, Nicolas Thiéry |
This comment has been minimized.
This comment has been minimized.
comment:3
Attachment: trac_14814-power_series_inverse_latex-fix-fh.patch.gz this may interfere with #14334 |
comment:5
It seems that there is no conflict with #14334 2 remarks:
|
comment:6
I have made a review patch. If you are happy with the few small changes I have made, you can set a positive review. |
Reviewer: Frédéric Chapoton |
comment:7
Attachment: trac_14814_review.patch.gz Ping ! Florent ? anybody else ? |
comment:8
Ping again ! Nobody available to have a look at this ticket ? |
another review patch, atop of the previous one |
comment:9
Attachment: trac_14814-review-2-dg.patch.gz New review patch allows the denominator to lie in a different parent (as long as it coerces into that of the numerator), deals with an endless-loop bug, and adds doc and comments. If you are fine with it, Frederic and Florent, this is positive_review! for the patchbot apply trac_14814-power_series_inverse_latex-fix-fh.patch trac_14814_review.patch trac_14814-review-2-dg.patch |
This comment has been minimized.
This comment has been minimized.
Branch: u/vbraun/series_integral_div |
Commit: |
comment:12
Thanks for the final review, Volker! |
Changed author from Florent Hivert, Nicolas Thiéry to Florent Hivert, Nicolas M. Thiéry |
I also implement division by a non unit series (thanks Nicolas for preliminary code) and fixes the latex method which was buggy
Apply:
Component: algebra
Keywords: integral multivariate power series
Author: Florent Hivert, Nicolas M. Thiéry
Branch/Commit: u/vbraun/series_integral_div @
02333e3
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/14814
The text was updated successfully, but these errors were encountered: