Update to MPIR 2.7.0-alpha12 #15015

jpflori · 2013-08-06T21:44:07Z

MPIR 2.6.0 does not build on Cygwin 64.
The next version should fix this problem (and others).
Patches from Sage will mostly be integrated.

upstream at: http://mpir.org/mpir-2.7.0-alpha12.tar.bz2

Upstream: Fixed upstream, but not in a stable release.

CC: @kcrisman @dimpase @tscrim @williamstein

Component: packages: standard

Keywords: mpir spkg cygwin

Author: Jean-Pierre Flori, Jeroen Demeyer

Branch/Commit: d97c066

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/15015

The text was updated successfully, but these errors were encountered:

jpflori · 2013-08-06T21:44:40Z

comment:1

This should surely be renamed to "Update to MPIR 2.6.1" when the official version get released (no idea when...).

jpflori · 2013-08-07T08:59:57Z

Author: Jean-Pierre Flori

jdemeyer · 2013-08-07T09:55:10Z

Dependencies: MPIR 2.6.1 upstream

tscrim · 2013-08-10T19:37:01Z

comment:4

For the record, the current spkg built for me on cygwin64.

jpflori · 2013-11-06T09:34:33Z

comment:5

On top of that the current MPIR 2.6.0 fails to properly build on Cygwin when CXX support is not enabled.
Therefore it is not possible/easy to build GCC on Cygwin.
That is because of a dirty hack in the autotools stuff already present in GMP before MPIR was forked.
This is also fixed in the current git version.

nexttime · 2014-04-06T19:14:49Z

comment:6

Otherwise we'd probably have to close it as won't fix. :-)

Current upstream tarball: http://mpir.org/mpir-2.7.0-alpha4.tar.bz2

Still needs to be tested on Darwin PowerPC I think. (moufang? Does it still live?)

And probably also Macs with more recent versions of Xcode.

kcrisman · 2014-04-09T18:02:26Z

comment:7

So are you saying that JP should make a tarball for this as an alpha? I don't have time to test this on PPC until that exists. Currently trying to built 6.2.beta7, I'll wait until I get a clean build for that platform before I try new things. (Hopefully rpy is the only remaining problem there.)

nexttime · 2014-04-09T18:19:35Z

comment:8

Replying to @kcrisman:

So are you saying that JP should make a tarball for this as an alpha?

I think that would be convenient for testing, and there are still some issues on Cygwin* JP knows about.

By the way, note that the latest changes in the alpha4 tarball aren't yet committed on github (it's still at alpha3).

jpflori · 2014-04-09T21:14:56Z

comment:9

Replying to @kcrisman:

So are you saying that JP should make a tarball for this as an alpha? I don't have time to test this on PPC until that exists. Currently trying to built 6.2.beta7, I'll wait until I get a clean build for that platform before I try new things. (Hopefully rpy is the only remaining problem there.)

I happens I did and almost have an almost completely working out of the box cygwin64 branch.
I just have to cherry-pick commits and push them to different branches on trac.

jpflori · 2014-04-13T19:46:01Z

comment:10

There are still issues with PPL...
See https://groups.google.com/forum/?fromgroups=#!topic/mpir-devel/JFDaMAc0YpY

New commits:

`a564118`	`Update MPIR to 2.7.0.alpha4`
`5d7a2e9`	`Remove unnecessary fix for MPIR.`

jpflori · 2014-04-13T19:46:01Z

Changed dependencies from MPIR 2.6.1 upstream to none

jpflori · 2014-04-13T19:46:01Z

Commit: 5d7a2e9

jpflori · 2014-04-13T19:46:01Z

Branch: u/jpflori/ticket/15015

nexttime · 2014-04-14T00:16:57Z

comment:11

A few comments/questions:

Do we lose the Clang / XCode 5 patch? (I did have other clang patches elsewhere, also just preventing configure to fail for no real reason.)
Sun compiler patch (probably less important)?
What is patch ... || continue supposed to achieve? (The if [ $? -ne 0 ] afterwards gets useless.)
In if uname -a | grep x86_64; then ... any output (stdout and stderr) should get redirected to /dev/null.

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

nexttime · 2014-04-14T01:00:29Z

comment:12

I recall we also had issues with AVX-enabled CPUs on Darwin and (not that) old Apple assemblers not supporting AVX instructions. IIRC Jeroen removed a work-around (with a bunch of other things dealing with proper CFLAGS) from spkg-install a while ago, so this is presumably no longer an issue (just because we meanwhile require some more recent version of Xcode I guess), but I might be wrong.

jpflori · 2014-04-14T08:09:28Z

comment:13

Replying to @nexttime:

A few comments/questions:

All (Most?) should be upstream now if I did not screw up a long time ago.

Do we lose the Clang / XCode 5 patch? (I did have other clang patches elsewhere, also just preventing configure to fail for no real reason.)

Must admit I don't remember about that one.

Sun compiler patch (probably less important)?

This one is in (IIRC).

What is patch ... || continue supposed to achieve? (The if [ $? -ne 0 ] afterwards gets useless.)

When there is no patch at all I guess.
Not sure naymore.

In if uname -a | grep x86_64; then ... any output (stdout and stderr) should get redirected to /dev/null.

Maybe!

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

The CXXFLAGS issue should be fixed in MPIR (maybe not alpha4, but in git master).

jpflori · 2014-04-14T08:10:24Z

comment:14

Replying to @nexttime:

I recall we also had issues with AVX-enabled CPUs on Darwin and (not that) old Apple assemblers not supporting AVX instructions. IIRC Jeroen removed a work-around (with a bunch of other things dealing with proper CFLAGS) from spkg-install a while ago, so this is presumably no longer an issue (just because we meanwhile require some more recent version of Xcode I guess), but I might be wrong.

I don't now.
We surely added thing for apple ocmpiler/assembler/linker but couldn't promise it was AVX related.

nexttime · 2014-04-14T08:19:26Z

comment:15

Replying to @jpflori:

Replying to @nexttime:

Should #16149 be added as a dependency of this ticket, or do you want to deal with that in MPIR's spkg-install? (I'd prefer the former, but am also undecided about the solution to choose on #16149, hence "needs info".)

The CXXFLAGS issue should be fixed in MPIR (maybe not alpha4, but in git master).

No, a slightly different one (but with the same effect). AC_PROG_CXX in MPIR is now correctly called after CXXFLAGS have been saved, and MPIR now behaves correctly (I'd say). But Sage sets (and exports) CXXFLAGS to the empty string, so MPIR doesn't touch them (again assuming they were intentionally set), such that we end up with missing flags (unless the user had really set them, or CFLAGS, to something meaningful).

jpflori · 2014-10-31T09:49:14Z

comment:48

I don't really agree...
If we keep on like that Sage will grow huge.
Hard disks are cheap but internet connections aren't always, e.g. I get a poor bandwith between my office and boxen.
Let's discuss this on sage-devel.

jpflori · 2014-10-31T09:55:24Z

comment:49

https://groups.google.com/forum/#!topic/sage-devel/a9yIdaqNHKU

jpflori · 2014-11-24T14:11:51Z

comment:50

The gcdext change in MPIR was to be expected (at least the gcdext(1,1) example Jeroen found) and I personally don't think it's a bug.
I'm not sure what Bill will think though.

At the very least it makes MPIR consistent with GMP.

jpflori · 2014-11-24T14:12:17Z

comment:51

(And ok for not shipping any spkg-src script.)

jpflori · 2014-12-16T09:45:32Z

comment:53

The only thing really annoying me right now is the name of the tarball.
When we update to another alpha or the final version it will be a pain, so we should still repackage the upstream tarball to change the dir name wihtin it (rather than renaming the tarball).

jpflori · 2014-12-23T16:47:54Z

Work Issues: fix tarball name issue

jdemeyer · 2014-12-24T09:21:16Z

Changed work issues from fix tarball name issue to none

sagetrac-git · 2014-12-24T09:21:31Z

Changed commit from 8c7fbbd to aefe0eb

sagetrac-git · 2014-12-24T09:21:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`aefe0eb`	`Upgrade to MPIR 2.7.0-alpha12`

jdemeyer · 2014-12-24T09:22:05Z

New commits:

`aefe0eb`	`Upgrade to MPIR 2.7.0-alpha12`

sagetrac-git · 2014-12-24T09:27:49Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3d583af`	`Merge remote-tracking branch 'origin/develop' into ticket/15015`
`d97c066`	`Rename source directory`

sagetrac-git · 2014-12-24T09:27:49Z

Changed commit from aefe0eb to d97c066

jpflori · 2014-12-24T10:50:53Z

comment:60

Looks fine.

I had a vague souvenir we had trouble with dashes in version numbers but it does not seem to be the case anymore.
Maybe we could also switch back to verbatim version numbers for Singular 4-0-1.

jpflori · 2014-12-24T11:36:41Z

comment:61

Got two files with failing doctests but cannot reproduce these failures:

src/sage/modular/modform/ambient.py
src/sage/graphs/genus.pyx

vbraun · 2015-01-02T15:46:28Z

Changed branch from u/jdemeyer/ticket/15015 to d97c066

jpflori added this to the sage-5.12 milestone Aug 6, 2013

jpflori added c: packages: standard labels Aug 6, 2013

This comment has been minimized.

Sign in to view

jdemeyer removed this from the sage-5.12 milestone Aug 7, 2013

jdemeyer added the pending label Aug 7, 2013

jdemeyer changed the title ~~Let MPIR >=2.6.0 build on Cygwin~~ Update to MPIR 2.6.1 when it's released Aug 7, 2013

nexttime mannequin changed the title ~~Update to MPIR 2.6.1 when it's released~~ Update to MPIR 2.7.0 when it's released Apr 6, 2014

This comment has been minimized.

Sign in to view

jpflori added the s: needs info label Nov 24, 2014

jpflori added s: needs work and removed s: needs info labels Dec 23, 2014

This comment has been minimized.

Sign in to view

jdemeyer added s: needs review and removed s: needs work labels Dec 24, 2014

jdemeyer added this to the sage-6.5 milestone Dec 24, 2014

jdemeyer removed the pending label Dec 24, 2014

jdemeyer changed the title ~~Update to MPIR 2.7.0 when it's released~~ Update to MPIR 2.7.0-alpha12 Dec 24, 2014

jpflori added s: positive review and removed s: needs review labels Dec 24, 2014

vbraun removed the s: positive review label Jan 2, 2015

vbraun closed this as completed in 2dfc6a0 Jan 2, 2015

jpflori mentioned this issue Nov 28, 2014

Old FSF config.(guess|sub) scripts do not recognize Cygwin64 #14648

Closed

jdemeyer mentioned this issue Jan 4, 2015

Move ManinSymbol class #17579

Closed

Update to MPIR 2.7.0-alpha12 #15015

Update to MPIR 2.7.0-alpha12 #15015

Comments

jpflori commented Aug 6, 2013

jpflori commented Aug 6, 2013

This comment has been minimized.

jpflori commented Aug 7, 2013

jdemeyer commented Aug 7, 2013

This comment has been minimized.

tscrim commented Aug 10, 2013

jpflori commented Nov 6, 2013

nexttime mannequin commented Apr 6, 2014

kcrisman commented Apr 9, 2014

nexttime mannequin commented Apr 9, 2014

jpflori commented Apr 9, 2014

jpflori commented Apr 13, 2014

jpflori commented Apr 13, 2014

jpflori commented Apr 13, 2014

jpflori commented Apr 13, 2014

This comment has been minimized.

nexttime mannequin commented Apr 14, 2014

nexttime mannequin commented Apr 14, 2014

jpflori commented Apr 14, 2014

jpflori commented Apr 14, 2014

nexttime mannequin commented Apr 14, 2014

jpflori commented Oct 31, 2014

jpflori commented Oct 31, 2014

jpflori commented Nov 24, 2014

jpflori commented Nov 24, 2014

jpflori commented Dec 16, 2014

jpflori commented Dec 23, 2014

This comment has been minimized.

jdemeyer commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

jdemeyer commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

sagetrac-git mannequin commented Dec 24, 2014

jpflori commented Dec 24, 2014

jpflori commented Dec 24, 2014

vbraun commented Jan 2, 2015