Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pushout of completed fields #15329

Closed
simon-king-jena opened this issue Oct 26, 2013 · 6 comments
Closed

Fix pushout of completed fields #15329

simon-king-jena opened this issue Oct 26, 2013 · 6 comments
Labels
c: coercion p: major / 3 t: bug
Milestone
sage-6.1

Comments

@simon-king-jena
Copy link
Member

The aim is to fix the following problem.

sage: from sage.categories.pushout import pushout
sage: pushout(Qp(7),RLF)
Traceback (most recent call last):
...
RuntimeError: maximum recursion depth exceeded while calling a Python object

This boils down to change how CompletionFunctor (which is a type of construction functors used both for RLF and Qp(7)) commutes with other construction functors. Currently, it commutes with the fraction field functor and with other completion functors. But in fact it is simply not true that construction functors commute.

Component: coercion

Author: Simon King

Branch/Commit: u/SimonKing/ticket/15329 @ 9d8e737

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/15329
@simon-king-jena simon-king-jena added this to the sage-6.1 milestone Oct 26, 2013
@simon-king-jena
Copy link
Member Author

Branch: u/SimonKing/ticket/15329

@simon-king-jena
Copy link
Member Author

New commits:

[changeset:9d8e737]Different completion functors must not commute, to fix pushout of completed fields

@simon-king-jena
Copy link
Member Author

Author: Simon King

@simon-king-jena
Copy link
Member Author

Commit: 9d8e737

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@mezzarobba
Copy link
Member

comment:3

Looks good to me.

@vbraun vbraun closed this as completed in f5cf3de Dec 21, 2013
@nbruin nbruin mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: coercion p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.1
Development

No branches or pull requests
3 participants
@vbraun @mezzarobba @simon-king-jena