Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cythonization of sage/combinat. #15412

Closed
robertwb opened this issue Nov 13, 2013 · 19 comments
Closed

Simplify cythonization of sage/combinat. #15412

robertwb opened this issue Nov 13, 2013 · 19 comments
Labels
c: build p: major / 3 t: bug
Milestone
sage-6.8

Comments

@robertwb
Copy link
Contributor

Use new glob-style pattern.

Depends on #17765

Component: build

Author: Robert Bradshaw, Jeroen Demeyer

Branch/Commit: 6e1038c

Reviewer: Nathann Cohen, Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/15412
@robertwb robertwb added this to the sage-5.13 milestone Nov 13, 2013
@robertwb
Copy link
Contributor Author

Branch: u/robertwb/ticket/15412

@robertwb
Copy link
Contributor Author

Commit: 34e9e11

@robertwb
Copy link
Contributor Author

New commits:

[34e9e11](https://github.com/sagemath/sagetrac-mirror/commit/34e9e11)Simplify combinat cythonization.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 13, 2013

comment:3

Same here. No need of gmp in expnums ?

Nathann

@robertwb
Copy link
Contributor Author

comment:4

See the change to sage/combinat/expnums.pyx

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 14, 2013

comment:5

Right, stupid me. I may have had combinat_cython in mind but anyway after deleting the build/ directory, building all files again then passing all tests I saw no doctest problem that seems to be related. SOooooooooo well :-)

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 14, 2013

Reviewer: Nathann Cohen

@jdemeyer
Copy link
Contributor

Author: Robert Bradshaw

@jdemeyer jdemeyer modified the milestones: sage-5.13, sage-6.0 Nov 14, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.0, sage-6.1 Dec 17, 2013
@vbraun
Copy link
Member

vbraun commented Dec 20, 2013

comment:8

Similar to #15410, but slightly different error in conway polynomials; http://build.sagemath.org/sage/builders/%20%20fast%20Volker%20Desktop%20%28Fedora%2019%20x86_64%29%20full/builds/6/steps/compile_1/logs/conway

@robertwb
Copy link
Contributor Author

comment:9

What exactly is the error?

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin removed this from the sage-6.3 milestone Aug 10, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin added this to the sage-6.4 milestone Aug 10, 2014
@jdemeyer
Copy link
Contributor

Changed author from Robert Bradshaw to Robert Bradshaw, Jeroen Demeyer

@jdemeyer
Copy link
Contributor

comment:13

Rebooting this ticket on top of #17765.

@jdemeyer
Copy link
Contributor

Dependencies: #17765

@jdemeyer jdemeyer modified the milestones: sage-6.4, sage-6.8 Jun 24, 2015
@jdemeyer
Copy link
Contributor

Changed branch from u/robertwb/ticket/15412 to u/jdemeyer/ticket/15412

@jdemeyer
Copy link
Contributor

Changed commit from 34e9e11 to 6e1038c

@jdemeyer
Copy link
Contributor

comment:16

Forgot to push...

New commits:

29df90cSimplify cythonization of sage/structure.
5d30cd6Merge tag '6.8.beta5' into t/17765/17765-simplify-structure
6e1038cSimplify cythonization of sage/combinat

@jpflori
Copy link
Contributor

jpflori commented Jul 1, 2015

Changed reviewer from Nathann Cohen to Nathann Cohen, Jean-Pierre Flori

@jpflori
Copy link
Contributor

jpflori commented Jul 1, 2015

comment:17

Looks god.

@vbraun
Copy link
Member

vbraun commented Jul 2, 2015

Changed branch from u/jdemeyer/ticket/15412 to 6e1038c

@vbraun vbraun closed this as completed in 8044966 Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.8
Development

No branches or pull requests
4 participants
@robertwb @vbraun @jpflori @jdemeyer