-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes to symmetric functions #15473
Comments
comment:1
So, here's the file... but... it fails doctests for no reason whatsoever!
This happens only because of the doctest
before it. Both doctests work fine in isolation, but it seems that the What the fuck??? |
comment:5
This is, sadly, not the patch where I'm touching QSym; I cc'ed you because it seems to be a category issue. Thanks for looking into it nevertheless! |
comment:6
Replying to @darijgr:
I see! Actually I thought that with Nicolas' modification of the C3 algorithm, an inconsistent method resolution order should never occur. |
comment:7
Nevermind my patch -- the bug is already triggered by
If I use two primes instead of There should be a contest for the shortest string that breaks Sage... |
comment:8
But... not all is well in field-land either!
|
without the offending doctest |
comment:10
Attachment: trac_15473-sym-dg.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:11
All is well that ends well -- it turns out that both bugs are fixed by the hg version of #10963. I'll open a new ticket to not lose track of this issue, but this patch can be reviewed independently of it since I've disabled the doctest. |
Branch: public/combinat/sf/fixes-15473 |
Commit: |
Reviewer: Travis Scrimshaw |
comment:12
Hey Darij, I've converted this to a branch, removed the deprecated functions (15 months old) except the k-Schurs (they are more tricky), and formally deprecated Best, Travis For the record, the doctests are re-enabled at #15475. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Thanks for the review again! Good job clearing up the deprecations. If these couple new changes are fine, please set to positive_review. |
comment:15
Looks good to me. |
Some doc fixed (mostly ReST errors, mostly due to myself).
is_integral_domain
added fwiw (maybe we can have the fraction field eventually).Some deprecated stuff is now lazy-imported rather than imported.
One doctest is disabled waiting for :trac:
10963
to be merged.CC: @tscrim @zabrocki @sagetrac-sage-combinat @simon-king-jena @nthiery
Component: combinatorics
Keywords: sage-combinat, symmetric functions
Author: Darij Grinberg
Branch/Commit: public/combinat/sf/fixes-15473 @
7f9be88
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/15473
The text was updated successfully, but these errors were encountered: